Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Error Prone 2.14.0 -> 2.15.0 #179

Merged
merged 4 commits into from
Sep 18, 2022
Merged

Upgrade Error Prone 2.14.0 -> 2.15.0 #179

merged 4 commits into from
Sep 18, 2022

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
com.google.errorprone:error_prone_annotations (source) compile minor 2.14.0 -> 2.15.0
com.google.errorprone:error_prone_core (source) minor 2.14.0 -> 2.15.0
com.google.errorprone:error_prone_test_helpers (source) compile minor 2.14.0 -> 2.15.0
com.google.errorprone:error_prone_core (source) compile minor 2.14.0 -> 2.15.0
com.google.errorprone:error_prone_check_api (source) compile minor 2.14.0 -> 2.15.0
com.google.errorprone:error_prone_annotation (source) compile minor 2.14.0 -> 2.15.0

Release Notes

google/error-prone

v2.15.0

Compare Source

New Checkers:

Fixed issues: #​1562, #​3236, #​3245, #​3321

Full Changelog: google/error-prone@v2.14.0...v2.15.0

  • If you want to rebase/retry this PR, click this checkbox.

@Picnic-Bot Picnic-Bot requested review from rickie and Stephan202 August 6, 2022 01:03
@Picnic-Bot
Copy link
Contributor Author

Suggested commit message:

Upgrade Error Prone 2.14.0 -> 2.15.0

See:
- https://github.com/google/error-prone/releases/tag/v2.15.0
- https://github.com/google/error-prone/compare/v2.14.0...v2.15.0

@Stephan202 Stephan202 force-pushed the renovate/version.error-prone-orig branch from c4528b1 to 6dccd76 Compare August 6, 2022 08:42
Stephan202
Stephan202 reviewed Aug 6, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a commit.

@Stephan202 Stephan202 force-pushed the renovate/version.error-prone-orig branch from 6dccd76 to 1e8ecbc Compare August 6, 2022 09:23
@Stephan202 Stephan202 changed the base branch from master to sschroevers/enable-VoidMissingNullable August 6, 2022 09:23
@Stephan202
Copy link
Member

Rebased PR on top of #180 and added another commit.

@Stephan202
Copy link
Member

Stephan202 commented Aug 6, 2022 •
edited
Loading

Suggested commit message:

Upgrade Error Prone 2.14.0 -> 2.15.0 (#179)

See:
- https://github.com/google/error-prone/releases/tag/v2.15.0
- https://github.com/google/error-prone/compare/v2.14.0...v2.15.0
- https://github.com/PicnicSupermarket/error-prone/compare/v2.14.0-picnic-2...v2.15.0-picnic-3

@Stephan202 Stephan202 mentioned this pull request Aug 6, 2022
Merged
rickie
rickie approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes & suggested commit message LGTM!

@Stephan202 Stephan202 mentioned this pull request Aug 6, 2022
Merged
@Stephan202 Stephan202 added this to the 0.1.1 milestone Aug 13, 2022
@Stephan202 Stephan202 force-pushed the sschroevers/enable-VoidMissingNullable branch from e89186b to 96a71ba Compare August 18, 2022 12:12
Base automatically changed from sschroevers/enable-VoidMissingNullable to master August 18, 2022 12:28
@rickie rickie modified the milestones: 0.1.1, 0.1.2 Aug 22, 2022
@Stephan202 Stephan202 force-pushed the renovate/version.error-prone-orig branch from 1e8ecbc to 623b64d Compare September 18, 2022 12:37
@Stephan202
Copy link
Member

Rebased and resolved conflicts. @rickie shall we merge this PR once built?

@rickie
Copy link
Member

rickie commented Sep 18, 2022

Sounds good, let's do it!

Internal PR for the upgrade should make it in the next release, that's the goal at least 😉.

@Stephan202 Stephan202 force-pushed the renovate/version.error-prone-orig branch from 623b64d to f2cad76 Compare September 18, 2022 13:19
@Stephan202
Copy link
Member

Rebased once more and upgraded to the latest version of our fork.

@Stephan202 Stephan202 merged commit b675ff6 into master Sep 18, 2022
@Stephan202 Stephan202 deleted the renovate/version.error-prone-orig branch September 18, 2022 13:25
@rickie rickie changed the title Upgrade version.error-prone-orig 2.14.0 -> 2.15.0 Upgrade Error Prone 2.14.0 -> 2.15.0 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
dependencies
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Picnic-Bot @Stephan202 @rickie