Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend TestNGToAssertJRules Refaster rule collection #1483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Dec 27, 2024

Suggested commit message:

Extend `TestNGToAssertJRules` Refaster rule collection (#1483)

By migrating all remaining `assertEquals` methods.

While working on this I found an issue; filed testng-team/testng#3199.

(Perhaps it's time to move this to an Error Prone check, but given that we don't use TestNG internally anymore, that's likely not worth the trouble. I opened this PR primarily because I had a branch with some of these changes, and decided it was time to "flush" that work.)

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the sschroevers/more-testng-to-assertj-rules branch from f501c9b to 94bff3e Compare December 28, 2024 17:02
@Stephan202 Stephan202 marked this pull request as ready for review December 28, 2024 17:04
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant