Introduce AssertThatString{Contains,DoesNotContain} Refaster rules
#1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Dec 25, 2024
Comment on lines
264
to
270
| Refaster.anyOf( | ||
| assertThat(iterable).hasSize(0), | ||
| assertThat(iterable.iterator().hasNext()).isFalse(), | ||
| assertThat(iterable.iterator()).isExhausted(), | ||
| assertThat(Iterables.size(iterable)).isEqualTo(0L), | ||
| assertThat(Iterables.size(iterable)).isNotPositive()); | ||
| } |
There was a problem hiding this comment.
The rules in this class are not yet tested, and require further cleanup/generalization. For now I just added this case here to keep track of it.
|
Looks good. No mutations were possible for these changes. |
rickie
approved these changes
Dec 25, 2024
While there, extend `AssertThatIterableIsEmpty`.
rickie
force-pushed
the
sschroevers/additional-assertj-string-rules
branch
from
1f50a21 to
b805efb
Compare
|
Nice 😄 |
|
Looks good. No mutations were possible for these changes. |
|
This was referenced Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message: