Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ExplicitArgumentEnumeration check #1475

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Improve ExplicitArgumentEnumeration check #1475

merged 2 commits into from
Dec 23, 2024

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Dec 22, 2024 •
edited
Loading

Suggested commit message:

Improve `ExplicitArgumentEnumeration` check (#1475)

Summary of changes:
- Also drop unnecessary `Immutable{List,Multiset,Set}#copyOf(E[])`
  invocations.
- Don't suggest simplifications that are likely to introduce unbounded
  recursion.

See also this comment.

@Stephan202 Stephan202 added this to the 0.20.0 milestone Dec 22, 2024
@Stephan202 Stephan202 mentioned this pull request Dec 22, 2024
Merged
@github-actions GitHub Actions
Copy link

Looks good. All 12 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.ExplicitArgumentEnumeration 0 12

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions GitHub Actions
Copy link

Looks good. All 12 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.ExplicitArgumentEnumeration 0 12

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

mohamedsamehsalah
mohamedsamehsalah approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@Stephan202
Improve ExplicitArgumentEnumeration check
fd165c9 
Summary of changes:
- Also drop unnecessary `Immutable{List,MultiSet,Set}#copyOf(E[])`
  invocations.
- Don't suggest simplifications that are likely to introduce unbounded
  recursion.
@Stephan202
More accurate comment
0bc4fa4
@Stephan202 Stephan202 force-pushed the sschroevers/ExplicitArgumentEnumeration-improvements branch from 36fd1dd to 0bc4fa4 Compare December 23, 2024 08:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Looks good. All 12 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.bugpatterns.ExplicitArgumentEnumeration 0 12

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie merged commit 2a3d9c8 into master Dec 23, 2024
16 checks passed
@rickie rickie deleted the sschroevers/ExplicitArgumentEnumeration-improvements branch December 23, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @mohamedsamehsalah