Fix Slf4jLoggerDeclaration flag name
#1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Nov 24, 2024
| @@ -53,7 +53,7 @@ public final class Slf4jLoggerDeclaration extends BugChecker implements Variable | |||
| private static final Matcher<ExpressionTree> IS_GET_LOGGER = | |||
| staticMethod().onDescendantOf("org.slf4j.LoggerFactory").named("getLogger"); | |||
| private static final String CANONICAL_STATIC_LOGGER_NAME_FLAG = | |||
| "Slf4jLogDeclaration:CanonicalStaticLoggerName"; | |||
| "Slf4jLoggerDeclaration:CanonicalStaticLoggerName"; | |||
There was a problem hiding this comment.
At some point we should likely write an error prone check that validates this :)
|
This change was split off from #1426; let's merge this PR first. |
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
sschroevers/align-flag-name
branch
from
ad3faf6 to
f658beb
Compare
|
Looks good. No mutations were possible for these changes. |
|
rickie
approved these changes
Nov 25, 2024
mohamedsamehsalah
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message: