Introduce NameContentEquals Refaster rule
#1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2024
Stephan202
commented
Oct 27, 2024
| @@ -67,4 +68,22 @@ String after(String value) { | |||
| return Constants.format(value); | |||
| } | |||
| } | |||
|
|
|||
| /** Prefer {@link Name#contentEquals(CharSequence)} over more verbose alternatives. */ | |||
| static final class NameContentEquals { | |||
There was a problem hiding this comment.
We can debate whether BugCheckerRules is the best place for this rule, but it's in line with other rule definitions in this class.
|
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
approved these changes
Oct 29, 2024
rickie
force-pushed
the
sschroevers/name-contentequals-rule
branch
from
524ad00 to
ff999de
Compare
|
|
Looks good. All 2 mutations in this change were killed.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As also flagged here and here.
Suggested commit message: