Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop public modifier from BugPattern tests #136

Merged
merged 2 commits into from
Jun 26, 2022
Merged

Drop public modifier from BugPattern tests #136

merged 2 commits into from
Jun 26, 2022

Conversation

rickie
Copy link
Member

@rickie rickie commented Jun 16, 2022

Noticed this inconsistency a while back and now is the time to remove it 😄.

@rickie rickie added this to the 0.1.0 milestone Jun 16, 2022
ibabiankou
ibabiankou approved these changes Jun 16, 2022
View reviewed changes
Copy link

@ibabiankou ibabiankou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

oxkitsune
oxkitsune approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@oxkitsune oxkitsune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rickie rickie modified the milestones: 0.1.0, 0.1.1 Jun 21, 2022
@Stephan202 Stephan202 force-pushed the rossendrijver/remove_modifiers branch from 9f24a69 to 15f3d5e Compare June 25, 2022 18:39
Stephan202
Stephan202 approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and extended a relevant comment in JUnitMethodDeclaration.

@Stephan202
Copy link
Member

Suggested commit message:

Drop `public` modifier from `BugPattern` test classes (#136)

@Stephan202 Stephan202 modified the milestones: 0.1.1, 0.1.0 Jun 25, 2022
@Stephan202 Stephan202 merged commit 17d5805 into master Jun 26, 2022
@Stephan202 Stephan202 deleted the rossendrijver/remove_modifiers branch June 26, 2022 09:20
rickie pushed a commit that referenced this pull request Oct 26, 2022
@Picnic-Bot
Upgrade pitest-maven-plugin 1.9.8 -> 1.9.9 (#136)
f3b8130 
See hcoles/pitest@1.9.8...1.9.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxkitsune oxkitsune oxkitsune approved these changes

@ibabiankou ibabiankou ibabiankou approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rickie @Stephan202 @ibabiankou @oxkitsune