Introduce CollectionIterator Refaster rule
#1347
Conversation
|
Looks good. No mutations were possible for these changes. |
By re-writing `Stream#iterator` statements.
Stephan202
force-pushed
the
mohamedsamehsalah/collection-iterator
branch
from
beb74e6 to
012b5e4
Compare
|
Looks good. No mutations were possible for these changes. |
|
There was a problem hiding this comment.
Added a commit and updated the suggested commit message. Nice suggestion @mohamedsamehsalah!
| * Don't call {@link ImmutableCollection#asList()} if {@link ImmutableCollection#iterator()} is | ||
| * called on the result; call it directly. | ||
| */ | ||
| /** Prefer {@link ImmutableCollection#iterator()} over more contrived alternatives. */ |
There was a problem hiding this comment.
We can also call out that these alternatives are likely less performant.
| static final class ImmutableCollectionIterator<T> { | ||
| @BeforeTemplate | ||
| Iterator<T> before(ImmutableCollection<T> collection) { | ||
| return collection.asList().iterator(); | ||
| return Refaster.anyOf(collection.stream().iterator(), collection.asList().iterator()); |
There was a problem hiding this comment.
I think it's due to copy-pasta from the rule above, but we can actually generalize the first expression to any Collection.
There was a problem hiding this comment.
Makes sense. I missed the generalization part 😅
Thanks @Stephan202 ❤️
| return ImmutableSet.of(1).asList().iterator(); | ||
| ImmutableSet<Iterator<Integer>> testImmutableCollectionIterator() { | ||
| return ImmutableSet.of( | ||
| ImmutableSet.of(1).stream().iterator(), ImmutableSet.of(1).asList().iterator()); |
There was a problem hiding this comment.
| ImmutableSet.of(1).stream().iterator(), ImmutableSet.of(1).asList().iterator()); | |
| ImmutableSet.of(1).stream().iterator(), ImmutableSet.of(2).asList().iterator()); |
It was actually your suggestion 🚀 Thanks for review. 😃 |
Stephan202
changed the title
ImmutableCollectionIterator refaster ruleCollectionIterator Refaster rule
Suggested commit message