Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have LexicographicalAnnotationAttributeListing also sort booleans and chars #1334

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Have LexicographicalAnnotationAttributeListing also sort booleans and chars #1334

merged 1 commit into from
Sep 30, 2024

Conversation

Stephan202
Copy link
Member

Suggested commit message:

Have `LexicographicalAnnotationAttributeListing` also sort booleans and chars

This is just the result of me going on a tangent while trying to understand something else.

@Stephan202 Stephan202 added this to the 0.19.0 milestone Sep 21, 2024
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie
rickie approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple improvement :D

mohamedsamehsalah
mohamedsamehsalah approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@Stephan202 Stephan202 force-pushed the sschroevers/more-attribute-sorting branch from 84e7fa4 to bf6802a Compare September 29, 2024 17:37
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Stephan202 Stephan202 merged commit 9cbc6f8 into master Sep 30, 2024
16 checks passed
@Stephan202 Stephan202 deleted the sschroevers/more-attribute-sorting branch September 30, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@rickie rickie rickie approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @mohamedsamehsalah