Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pitest-maven-plugin 1.16.1 -> 1.17.0 #1313

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

Picnic-DevPla-Bot
Copy link
Contributor

@Picnic-DevPla-Bot Picnic-DevPla-Bot commented Aug 29, 2024

This PR contains the following updates:

Package Type Update Change
pitest-maven-plugin (source) build minor 1.16.1 -> 1.17.0

Release Notes

hcoles/pitest (pitest-maven-plugin)

v1.17.0

Compare Source

  • #​1348 Extend transformation extension point
  • #​1349 Improve powermock stability

v1.16.3

Compare Source

  • #​1345 Improved delayed execution detection in static initialization code
  • #​1347 Auto add standard kotlin source dirs for maven projects

v1.16.2

Compare Source

#​1340 Show covering tests for surviving mutants in html report (thanks @​vivganes)
#​1342 / #​1343 Fix misleading logging of history paths (thanks @​vivganes)
#​1344 Mutate delayed execution code in enums and singletons


  • If you want to rebase/retry this PR, check this box

@Picnic-DevPla-Bot
Copy link
Contributor Author

Picnic-DevPla-Bot commented Aug 29, 2024

Suggested commit message:

Upgrade pitest-maven-plugin 1.16.1 -> 1.17.0

See:
- https://github.com/hcoles/pitest/releases/tag/1.16.2
- https://github.com/hcoles/pitest/releases/tag/1.16.3
- https://github.com/hcoles/pitest/releases/tag/1.17.0
- https://github.com/hcoles/pitest/compare/1.16.1...1.17.0

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reduces the number of mutations generated; discussion here :)

@Picnic-DevPla-Bot Picnic-DevPla-Bot force-pushed the renovate/pitest-maven-plugin-1.x branch from 6c8677a to f4633d7 Compare August 30, 2024 01:12
@Picnic-DevPla-Bot Picnic-DevPla-Bot changed the title Upgrade pitest-maven-plugin 1.16.1 -> 1.16.2 Upgrade pitest-maven-plugin 1.16.1 -> 1.16.3 Sep 3, 2024
@Picnic-DevPla-Bot Picnic-DevPla-Bot force-pushed the renovate/pitest-maven-plugin-1.x branch 3 times, most recently from e99ca90 to b935f19 Compare September 5, 2024 01:02
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested version 1.16.3. For error-prone-contrib the output is nearly identical to version 1.16.1. The overview reports different statistics only for JUnitValueSource. (I didn't open the other files to see whether matching coverage stats were generated by identical sets of mutants.)

For the JUnitValueSource:

  1. The new version omits one mutant that was previously killed. (A lambda expression defined in a static initialization context.)
  2. Generates three additional mutants that are executed only in a static context, and are thus unkillabe.

I'll report back here.

@Stephan202
Copy link
Member

Ah, didn't mean to approve yet pending reply to this message. Though given the small delta, also not opposed to merging.

@Stephan202 Stephan202 added this to the 0.19.0 milestone Sep 6, 2024
@Picnic-DevPla-Bot Picnic-DevPla-Bot force-pushed the renovate/pitest-maven-plugin-1.x branch 5 times, most recently from ed28fe4 to be2e816 Compare September 17, 2024 01:21
@Picnic-DevPla-Bot Picnic-DevPla-Bot changed the title Upgrade pitest-maven-plugin 1.16.1 -> 1.16.3 Upgrade pitest-maven-plugin 1.16.1 -> 1.17.0 Sep 18, 2024
@Picnic-DevPla-Bot Picnic-DevPla-Bot force-pushed the renovate/pitest-maven-plugin-1.x branch from be2e816 to 3fbf31a Compare September 18, 2024 01:25
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Copy link
Member

Had a look at 1.17.0: same as 1.16.3.

@rickie
Copy link
Member

rickie commented Sep 19, 2024

Let's indeed merge this one as you suggested before.

@rickie
Copy link
Member

rickie commented Sep 19, 2024

Thanks for checking and proactively communicating the issues :).

@rickie rickie merged commit 432cf45 into master Sep 19, 2024
16 checks passed
@rickie rickie deleted the renovate/pitest-maven-plugin-1.x branch September 19, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants