-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update step-security/harden-runner
configuration
#1271
Conversation
Looks good. No mutations were possible for these changes. |
I'll add a commit to add some wildcards, based on the feedback in #1246 (comment). |
af1579a
to
87f6de4
Compare
Rebased and added two commits: one that introduces wildcards in all "relevant" places, and a second that reverts half of the changes. For some domains one could argue that using a wildcard is too liberal. I think that the current proposal strikes a nice balance between security and maintainability. |
Looks good. No mutations were possible for these changes. |
ea6ne4j2sb.execute-api.eu-central-1.amazonaws.com:443 | ||
github.com:443 | ||
objects.githubusercontent.com:443 | ||
repo.maven.apache.org:443 | ||
sc-cleancode-sensorcache-eu-central-1-prod.s3.amazonaws.com:443 | ||
scanner.sonarcloud.io:443 | ||
*.sonarcloud.io:443 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔*sonarcloud.io:443
would also work if we want to
I didn't saw the update in the other PR, sorry.
While apparently the build doesn't fail without this, it is reasonable for SonarCloud analysis to access the two additional domains.
87f6de4
to
92e3cde
Compare
Looks good. No mutations were possible for these changes. |
Quality Gate passedIssues Measures |
Suggested commit message:
Example runs that attempted to access these domains:
analysis-sensorcache-eu-central-1-prod.s3.amazonaws.com:443
api.nuget.org:443