Introduce FluxFromStreamSupplier Refaster rule
#1261
Conversation
| * may defer initiation of the asynchronous computation until subscription. | ||
| */ | ||
| static final class FluxFromStreamSupplier<T> { | ||
| @BeforeTemplate |
There was a problem hiding this comment.
| @BeforeTemplate | |
| // XXX: Constrain the `stream` parameter using `@NotMatches(IsIdentityOperation.class)` once | |
| // `IsIdentityOperation` no longer matches nullary method invocations. | |
| @BeforeTemplate |
Is this XXX also relevant in this case?
| @@ -641,4 +643,8 @@ Mono<Void> testMonoFromFutureSupplier() { | |||
| Mono<Void> testMonoFromFutureSupplierBoolean() { | |||
| return Mono.fromFuture(() -> CompletableFuture.completedFuture(null), true); | |||
| } | |||
|
|
|||
| Flux<Integer> testFluxFromStreamSupplier() { | |||
| return Flux.fromStream(() -> RandomGenerator.StreamableGenerator.of(1)); | |||
There was a problem hiding this comment.
Damn, I'm not sure what I was doing here 😬.
There was a problem hiding this comment.
I think something with auto-complete I'd say, but slipped through.
| * may defer initiation of the asynchronous computation until subscription. | ||
| */ | ||
| static final class FluxFromStreamSupplier<T> { | ||
| @BeforeTemplate |
| @@ -1913,7 +1914,7 @@ Duration after(StepVerifier.LastStep step, Duration duration) { | |||
|
|
|||
| /** | |||
| * Prefer {@link Mono#fromFuture(Supplier)} over {@link Mono#fromFuture(CompletableFuture)}, as | |||
| * the former may defer initiation of the asynchornous computation until subscription. | |||
| * the former may defer initiation of the asynchronous computation until subscription. | |||
There was a problem hiding this comment.
Nice one; should also be fixed below.
| static final class FluxFromStreamSupplier<T> { | ||
| @BeforeTemplate | ||
| Flux<T> before(Stream<T> stream) { | ||
| return Flux.fromStream(stream); |
There was a problem hiding this comment.
This triggers an interaction with FluxFromIterable, so more changes are necessary; will apply.
| /** | ||
| * Prefer {@link Flux#fromStream(Supplier)} over {@link Flux#fromStream(Stream)}, as the former | ||
| * may defer initiation of the asynchronous computation until subscription. | ||
| */ |
There was a problem hiding this comment.
Not related to asynchronicity 👀.
| /** | |
| * Prefer {@link Flux#fromStream(Supplier)} over {@link Flux#fromStream(Stream)}, as the former | |
| * may defer initiation of the asynchronous computation until subscription. | |
| */ | |
| /** | |
| * Prefer {@link Flux#fromStream(Supplier)} over {@link Flux#fromStream(Stream)}, as the former | |
| * yields a {@link Flux} that is more likely to behave as expected when subscribed to more than | |
| * once. | |
| */ |
|
Looks good. No mutations were possible for these changes. |
rickie
force-pushed
the
rossendrijver/flux_from_stream
branch
from
825d644 to
0eedcae
Compare
|
Looks good. No mutations were possible for these changes. |
|
No description provided.