Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend FluxJust Refaster rule #1253

Merged
merged 4 commits into from
Jul 20, 2024
Merged

Extend FluxJust Refaster rule #1253

merged 4 commits into from
Jul 20, 2024

Conversation

tijana-ninkovic
Copy link
Contributor

@tijana-ninkovic tijana-ninkovic commented Jul 17, 2024 •
edited
Loading

Summary

This PR adds another case for the FluxJust rule, which replaces the following pattern

Mono.just(value).repeat().take(1);

with

Flux.just(value);

Suggested Commit Message

Extend `FluxJust` Refaster rule (#1253)

@tijana-ninkovic tijana-ninkovic requested a review from rickie July 17, 2024 09:47
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie added this to the 0.17.0 milestone Jul 17, 2024
@tijana-ninkovic tijana-ninkovic requested a review from rickie July 18, 2024 08:23
@tijana-ninkovic tijana-ninkovic changed the title Introduce Reactor MonoJustRepeatTakeOne Refaster rule Introduce new case for Reactor FluxJust Refaster rule Jul 18, 2024
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

rickie
rickie approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@rickie rickie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Suggested commit message:

Extend `FluxJust` Refaster rule (#1253)

...e-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java Outdated
@@ -182,8 +182,8 @@ ImmutableSet<Flux<?>> testFluxEmpty() {
Flux.range(0, 0));
}

Flux<Integer> testFluxJust() {
return Flux.range(0, 1);
ImmutableSet<Flux<?>> testFluxJust() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can be specific here and keep Integer :).

@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 changed the title Introduce new case for Reactor FluxJust Refaster rule Extend FluxJust Refaster rule Jul 20, 2024
@Stephan202 Stephan202 force-pushed the tijana-ninkovic/reactor-mono-to-flux branch from 99b7a7e to fe2d5a8 Compare July 20, 2024 09:26
Stephan202
Stephan202 approved these changes Jul 20, 2024
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and added a tiny commit. Congrats on your first contribution here, @tijana-ninkovic!

@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie force-pushed the tijana-ninkovic/reactor-mono-to-flux branch from fe2d5a8 to 8112de2 Compare July 20, 2024 10:45
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickie rickie merged commit 2e5d1f1 into master Jul 20, 2024
15 checks passed
@rickie rickie deleted the tijana-ninkovic/reactor-mono-to-flux branch July 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie approved these changes

@Stephan202 Stephan202 Stephan202 approved these changes

Assignees
No one assigned
Labels
new feature
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tijana-ninkovic @Stephan202 @rickie