Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Servlet API 4.0.4 -> 6.0.0 #119

Merged
merged 2 commits into from
May 13, 2023

Conversation

Picnic-Bot
Copy link
Contributor

@Picnic-Bot Picnic-Bot commented Jun 3, 2022

This PR contains the following updates:

Package Type Update Change
jakarta.servlet:jakarta.servlet-api (source) compile major 4.0.4 -> 6.0.0

Release Notes

eclipse-ee4j/servlet-api

v6.0.0

Compare Source

v5.0.0

Compare Source


  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Jun 3, 2022

Suggested commit message:

Upgrade Servlet API 4.0.4 -> 6.0.0 (#119)

See https://github.com/eclipse-ee4j/servlet-api/compare/4.0.4-RELEASE...6.0.0

@Stephan202
Copy link
Member

This PR replaces #68. We can't yet merge this PR because it migrates from the javax to jakara namespace, while downstream we still use javax.

@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 3 times, most recently from 54dfe1b to 9f45bec Compare June 10, 2022 06:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 3 times, most recently from 0b7f434 to 12b946b Compare June 17, 2022 06:02
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 5 times, most recently from 6f580c5 to 452d44d Compare June 27, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 4 times, most recently from 5086862 to b3a754a Compare July 1, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 3 times, most recently from dc67941 to c78c97f Compare July 14, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 2 times, most recently from f66b173 to eaa4046 Compare July 22, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 6 times, most recently from dde2d26 to 668f271 Compare August 6, 2022 01:03
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 4 times, most recently from 3551d61 to 6f4b997 Compare October 18, 2022 01:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch 6 times, most recently from a984de2 to da01651 Compare October 27, 2022 01:01
@rickie rickie added the blocked This blocks either a release or a downstream project label Nov 2, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch from da01651 to 0db889d Compare April 28, 2023 19:26
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the changes in #543 the only thing that prevented this build from passing was an update to the test code. I added a commit; I think there's no harm in merging this PR, even though internally we haven't yet upgraded (but we likely will this quarter still).

@Stephan202 Stephan202 requested a review from rickie April 28, 2023 20:10
@Stephan202 Stephan202 added this to the 0.10.0 milestone Apr 28, 2023
@Stephan202 Stephan202 removed blocked This blocks either a release or a downstream project pause renovate Stop automatic rebasing labels Apr 28, 2023
@Picnic-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rickie rickie modified the milestones: 0.10.0, 0.11.0 May 4, 2023
@rickie rickie force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch from 2af8f3c to 3918fd7 Compare May 13, 2023 15:01
@github-actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rickie rickie merged commit 454e866 into master May 13, 2023
@rickie rickie deleted the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch May 13, 2023 15:11
@Stephan202 Stephan202 changed the title Upgrade jakarta.servlet:jakarta.servlet-api 4.0.4 -> 6.0.0 Upgrade Servlet API 4.0.4 -> 6.0.0 May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants