Introduce Check{Argument,State}WithMessageAndArguments Refaster rules
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stephan202
commented
Apr 13, 2024
| * Prefer {@link Preconditions#checkArgument(boolean, String, Object...)} over more verbose | ||
| * alternatives. | ||
| */ | ||
| // XXX: This check assumes that the format string only uses `%s` placeholders. |
There was a problem hiding this comment.
So this isn't fully correct. One option is to create an BugChecker instead, but that's more work 🤔
There was a problem hiding this comment.
Okay, I went down the rabbit hole: #1139.
|
Looks good. No mutations were possible for these changes. |
|
Stephan202
commented
Apr 14, 2024
| * Prefer {@link Preconditions#checkArgument(boolean, String, Object...)} over more verbose | ||
| * alternatives. | ||
| */ | ||
| // XXX: This check assumes that the format string only uses `%s` placeholders. |
There was a problem hiding this comment.
Okay, I went down the rabbit hole: #1139.
Stephan202
deleted the
sschroevers/prevent-unnecessary-precondition-formatting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message:
The tests pass, but when I run this against an internal code base relevant violations aren't replaced. Requires a deeper look.