Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Project Reactor 2023.0.2 -> 2023.0.3 #1034

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Picnic-Bot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
Project Reactor (source) import patch 2023.0.2 -> 2023.0.3

Release Notes

reactor/reactor (Project Reactor)

v2023.0.3

Compare Source

2023.0.3 release train is made of:

reactor-core 3.6.3
reactor-netty 1.1.16
reactor-kafka 1.3.23

These artifacts didn't have any changes:

reactor-pool 1.0.5
reactor-addons 3.5.1
reactor-kotlin-extensions 1.2.2


  • If you want to rebase/retry this PR, check this box

@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Feb 15, 2024

Suggested commit message:

Upgrade Project Reactor 2023.0.2 -> 2023.0.3 (#1034)

See:
- https://github.com/reactor/reactor/releases/tag/2023.0.3
- https://github.com/reactor/reactor/compare/2023.0.2...2023.0.3

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 added this to the 0.16.0 milestone Feb 15, 2024
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to suggest adding this Refaster rule (plus a variant):

/** Prefer {@link Flux#using(Callable, Function)} over more verbose alternatives. */
static final class FluxUsing<R extends AutoCloseable, T> {
  @BeforeTemplate
  Flux<T> before(
      Callable<? extends R> resourceSupplier,
      Function<? super R, ? extends Publisher<? extends T>> sourceSupplier) {
    return Flux.using(resourceSupplier, sourceSupplier, R::close);
  }

  @AfterTemplate
  Flux<T> after(
      Callable<? extends R> resourceSupplier,
      Function<? super R, ? extends Publisher<? extends T>> sourceSupplier) {
    return Flux.using(resourceSupplier, sourceSupplier);
  }
}

... but because R::close can throw an Exception, this won't compile.

@Picnic-Bot Picnic-Bot force-pushed the renovate/project-reactor-2023.x branch from e2b1133 to e002376 Compare February 16, 2024 02:04
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickie rickie merged commit cc6211d into master Feb 16, 2024
14 checks passed
@rickie rickie deleted the renovate/project-reactor-2023.x branch February 16, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants