Introduce error-prone-experimental module
#1003
Conversation
| <artifactId>error-prone-experimental</artifactId> | ||
|
|
||
| <name>Picnic :: Error Prone Support :: Experimental</name> | ||
| <description>Experimental Error Prone checks.</description> |
There was a problem hiding this comment.
Had no better idea as my alternatives all got a bit too long.
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
rossendrijver/ep-utilities-module
branch
from
270c65c to
947914a
Compare
Stephan202
force-pushed
the
rossendrijver/ep_experimental_module
branch
from
f3360c6 to
ba721eb
Compare
|
Looks good. No mutations were possible for these changes. |
| @@ -24,7 +24,7 @@ | |||
| * A {@link BugChecker} that flags lambda expressions that can be replaced with a method reference | |||
| * of the form {@code T.class::isInstance}. | |||
| * | |||
| * @see MethodReferenceUsage | |||
| * <p>See the `MethodReferenceUsage` check in the `error-prone-experimental` module. | |||
There was a problem hiding this comment.
Here and below: instead of backticks we should use {@code ..}. But since there's a corresponding XXX comment: let's drop.
error-prone-experimental/README.md
Outdated
| This module contains Error Prone checks that are currently under development or | ||
| evaluation. These checks may be works-in-progress or have uncertain impacts on | ||
| code. Having this module allows for controlled experimentation and refinement | ||
| before integration into production environments. |
There was a problem hiding this comment.
| This module contains Error Prone checks that are currently under development or | |
| evaluation. These checks may be works-in-progress or have uncertain impacts on | |
| code. Having this module allows for controlled experimentation and refinement | |
| before integration into production environments. | |
| This module contains Error Prone checks that are currently under development or | |
| evaluation. These checks may be works-in-progress or have uncertain impact on | |
| code. Having this module allows for controlled experimentation and refinement | |
| before integration into production environments. |
error-prone-experimental/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.assertj</groupId> | ||
| <artifactId>assertj-core</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.jspecify</groupId> | ||
| <artifactId>jspecify</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> |
There was a problem hiding this comment.
There are a few more unused dependencies here; will drop.
There was a problem hiding this comment.
We should change the package name, in preparation for one day adopting the Java module system (which doesn't allow packages to be split between modules).
I'm proposing tech.picnic.errorprone.experimental.bugpatterns.
|
Looks good. No mutations were possible for these changes. |
rickie
force-pushed
the
rossendrijver/ep-utilities-module
branch
from
947914a to
730c089
Compare
rickie
force-pushed
the
rossendrijver/ep_experimental_module
branch
from
eb21d65 to
f1be860
Compare
|
Rebased and resolved conflict. Will merge once 🍏. |
|
Looks good. No mutations were possible for these changes. |
Stephan202
force-pushed
the
rossendrijver/ep_experimental_module
branch
from
f1be860 to
c55ccfb
Compare
|
Looks good. No mutations were possible for these changes. |
|
❗ This PR is on top of #1000. ❗