Extend JUnitToAssertJRules Refaster rule collection
#1484
+718
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By migrating all remaining `assertArrayEquals` methods.
|
Looks good. No mutations were possible for these changes. |
|
mohamedsamehsalah
approved these changes
Dec 29, 2024
| @AfterTemplate | ||
| @UseImportPolicy(STATIC_IMPORT_ALWAYS) | ||
| void after(boolean[] actual, String message, boolean[] expected) { | ||
| assertThat(actual).withFailMessage(message).containsExactly(expected); |
There was a problem hiding this comment.
I wanted to suggest the following to make the style consistent with AssertJThrowingCallableRules where we do the message assertion after the checking the expected value.
Suggested change
| assertThat(actual).withFailMessage(message).containsExactly(expected); | |
| assertThat(actual).containsExactly(expected).withFailMessage(message); |
But Intellij warns Result of 'AbstractAssert. withFailMessage()' is ignored ; which I think is because of @CheckReturnValue annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message:
Analogous to #1483, this is me putting up a PR for a existing branch, this time after extending the work with the help of GitHub Copilot. (Also here, perhaps an Error Prone check is in order, but not today.)