Include a rule to rewrite Mono.just(null) to Mono.empty()

Should never happen in practice, but it's not a compile time error.
PicnicSupermarket · Dec 6, 2022 · f54d023 · f54d023
1 parent e05a3fb
commit f54d023
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java
@@ -64,7 +64,7 @@ Mono<T> after(Supplier<? extends T> supplier) {
   static final class MonoEmpty<T> {
     @BeforeTemplate
     Mono<T> before() {
-      return Mono.justOrEmpty(null);
+      return Refaster.anyOf(Mono.just(null), Mono.justOrEmpty(null));
     }
 
     @AfterTemplate

diff --git a/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java b/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java
@@ -34,8 +34,8 @@ ImmutableSet<Mono<?>> testMonoFromSupplier() {
         Mono.fromCallable(this::toString));
   }
 
-  Mono<String> testMonoEmpty() {
-    return Mono.justOrEmpty(null);
+  ImmutableSet<Mono<String>> testMonoEmpty() {
+    return ImmutableSet.of(Mono.just(null), Mono.justOrEmpty(null));
   }
 
   ImmutableSet<Mono<Integer>> testMonoJustOrEmpty() {

diff --git a/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java b/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java
@@ -37,8 +37,8 @@ ImmutableSet<Mono<?>> testMonoFromSupplier() {
         Mono.fromSupplier(this::toString));
   }
 
-  Mono<String> testMonoEmpty() {
-    return Mono.empty();
+  ImmutableSet<Mono<String>> testMonoEmpty() {
+    return ImmutableSet.of(Mono.empty(), Mono.empty());
   }
 
   ImmutableSet<Mono<Integer>> testMonoJustOrEmpty() {