Suggestions 2

PicnicSupermarket · Sep 9, 2022 · ee7a386 · ee7a386
1 parent d4e18bc
commit ee7a386
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/...r-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/NullTemplates.java b/...r-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/NullTemplates.java
@@ -58,10 +58,9 @@ Predicate<T> after() {
   }
 
   /**
-   * Prefer the <code>==</code> operator over {@link java.util.Objects#isNull(Object)} for null
-   * checks.
+   * Prefer the {@code ==} operator over {@link java.util.Objects#isNull(Object)} for null checks.
    */
-  static final class ObjectEqualsNull {
+  static final class IsNull {
     @BeforeTemplate
     boolean before(@Nullable Object object) {
       return Objects.isNull(object);
@@ -74,10 +73,9 @@ boolean after(@Nullable Object object) {
   }
 
   /**
-   * Prefer the <code>!=</code> operator over {@link java.util.Objects#isNull(Object)} for null
-   * checks.
+   * Prefer the {@code !=} operator over {@link java.util.Objects#isNull(Object)} for null checks.
    */
-  static final class ObjectNotEqualsNull {
+  static final class IsNotNull {
     @BeforeTemplate
     boolean before(@Nullable Object object) {
       return Objects.nonNull(object);

diff --git a/...b/src/test/resources/tech/picnic/errorprone/refastertemplates/NullTemplatesTestInput.java b/...b/src/test/resources/tech/picnic/errorprone/refastertemplates/NullTemplatesTestInput.java
@@ -24,11 +24,11 @@ long testNonNullFunction() {
     return Stream.of("foo").filter(s -> s != null).count();
   }
 
-  boolean testObjectEqualsNull() {
+  boolean testIsNull() {
     return Objects.isNull("foo");
   }
 
-  boolean testObjectNotEqualsNull() {
+  boolean testIsNotNull() {
     return Objects.nonNull("foo");
   }
 }
diff --git a/.../src/test/resources/tech/picnic/errorprone/refastertemplates/NullTemplatesTestOutput.java b/.../src/test/resources/tech/picnic/errorprone/refastertemplates/NullTemplatesTestOutput.java
@@ -26,11 +26,11 @@ long testNonNullFunction() {
     return Stream.of("foo").filter(Objects::nonNull).count();
   }
 
-  boolean testObjectEqualsNull() {
+  boolean testIsNull() {
     return "foo" == null;
   }
 
-  boolean testObjectNotEqualsNull() {
+  boolean testIsNotNull() {
     return "foo" != null;
   }
 }