Skip to content

Commit

Permalink
Small typos and a annotation order swap
Browse files Browse the repository at this point in the history
  • Loading branch information
rickie committed Feb 11, 2024
1 parent 8eddac7 commit c7f03c7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
// XXX: As-is this checker assumes that a method is fully migrated if it is invoked inside at least
// one `@BeforeTemplate` method. A stronger check would be to additionally verify that:
// 1. Such invocations are not conditionally matched. That is, there should be no constraint on
// their context (i.e any surrounding code), and their parameters must be `@BeforeTemplate`
// their context (i.e. any surrounding code), and their parameters must be `@BeforeTemplate`
// method parameters with types that are not more restrictive than those of the method itself.
// Additionally, the result of non-void methods should be "returned" by the `@BeforeTemplate`
// method, so that Refaster will match any expression, rather than just statements. (One caveat
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
* indicated type.
*/
// XXX: Add support for `#unmigratedFields()`.
// XXX: Consider making this annotation `@Repeatable`, for cases where a single Refaster rules
// XXX: Consider making this annotation `@Repeatable`, for cases where a single Refaster rule
// collection migrates away from multiple types.
@Target(ElementType.TYPE)
@Retention(RetentionPolicy.SOURCE)
@Target(ElementType.TYPE)
public @interface TypeMigration {
/**
* The type migrated away from.
Expand Down

0 comments on commit c7f03c7

Please sign in to comment.