Address comments: Fix mutation tests

PicnicSupermarket · Nov 25, 2023 · a7f652e · a7f652e
1 parent e79584e
commit a7f652e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/...-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/CanonicalConstantFieldName.java b/...-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/CanonicalConstantFieldName.java
@@ -128,20 +128,16 @@ public Description matchCompilationUnit(CompilationUnitTree tree, VisitorState s
           if (IS_CONSTANT.matches(variableTree, state)
               && isFieldAccessModifierApplicable(variableTree, state)) {
             VarSymbol variableSymbol = ASTHelpers.getSymbol(variableTree);
+            String variableName = variableSymbol.getSimpleName().toString();
 
-            if (variableSymbol != null) {
-              String variableName = variableSymbol.getSimpleName().toString();
+            if (!isVariableUpperSnakeCase(variableName) && !isVariableNameExcluded(variableName)) {
+              String replacement = toUpperSnakeCase(variableName);
 
-              if (!isVariableUpperSnakeCase(variableName)
-                  && !isVariableNameExcluded(variableName)) {
-                String replacement = toUpperSnakeCase(variableName);
-
-                if (variableSymbols.stream()
-                    .noneMatch(s -> s.getSimpleName().toString().equals(replacement))) {
-                  fixBuilder.merge(SuggestedFixes.renameVariable(variableTree, replacement, state));
-                } else {
-                  reportConstantRenameBlocker(variableTree, replacement, state);
-                }
+              if (variableSymbols.stream()
+                  .noneMatch(s -> s.getSimpleName().toString().equals(replacement))) {
+                fixBuilder.merge(SuggestedFixes.renameVariable(variableTree, replacement, state));
+              } else {
+                reportConstantRenameBlocker(variableTree, replacement, state);
               }
             }
           }

diff --git a/...trib/src/test/java/tech/picnic/errorprone/bugpatterns/CanonicalConstantFieldNameTest.java b/...trib/src/test/java/tech/picnic/errorprone/bugpatterns/CanonicalConstantFieldNameTest.java
@@ -125,7 +125,7 @@ void excludeFlaggedConstants() {
   }
 
   @Test
-  void IncludePublicConstants() {
+  void includePublicConstants() {
     BugCheckerRefactoringTestHelper.newInstance(CanonicalConstantFieldName.class, getClass())
         .setArgs("-XepOpt:CanonicalConstantFieldName:IncludePublicConstantFields=true")
         .addInputLines(