Some feedback from yesterday ;)

PicnicSupermarket · Apr 9, 2022 · 9f7ddfa · 9f7ddfa
1 parent 51a522d
commit 9f7ddfa
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...ne-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonCheck.java b/...ne-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonCheck.java
@@ -99,10 +99,10 @@ private static Optional<Fix> tryMakeMethodCallMorePrecise(
 
   private static String mayPrefixWithTypeArguments(
       String preferredMethodName, MethodInvocationTree tree, Type cmpType, VisitorState state) {
-    int typeArguments = tree.getTypeArguments().size();
-    boolean methodNameIsComparing = preferredMethodName.equals("comparing");
+    int typeArgumentsCount = tree.getTypeArguments().size();
+    boolean methodNameIsComparing = "comparing".equals(preferredMethodName);
 
-    if (typeArguments == 0 || (typeArguments == 1 && !methodNameIsComparing)) {
+    if (typeArgumentsCount == 0 || (typeArgumentsCount == 1 && !methodNameIsComparing)) {
       return preferredMethodName;
     }