Check ASTHelpers.getSymbol for nulls

PicnicSupermarket · Jan 9, 2023 · 9a8b9b1 · 9a8b9b1
1 parent 9eb4bfe
commit 9a8b9b1
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/BadStaticImport.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/BadStaticImport.java
@@ -119,15 +119,15 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
 
   @Override
   public Description matchIdentifier(IdentifierTree tree, VisitorState state) {
-    Symbol symbol = ASTHelpers.getSymbol(tree);
-    if (isMatch(symbol)) {
-      return getDescription(tree, state, symbol);
+    if (isMatch(tree)) {
+      return getDescription(tree, state);
     }
 
     return Description.NO_MATCH;
   }
 
-  private Description getDescription(IdentifierTree tree, VisitorState state, Symbol symbol) {
+  private Description getDescription(IdentifierTree tree, VisitorState state) {
+    Symbol symbol = ASTHelpers.getSymbol(tree);
     SuggestedFix.Builder builder =
         SuggestedFix.builder().removeStaticImport(getImportToRemove(symbol));
     String replacement =
@@ -142,7 +142,12 @@ private static String getImportToRemove(Symbol symbol) {
         ".", symbol.getEnclosingElement().getQualifiedName(), symbol.getSimpleName());
   }
 
-  private static boolean isMatch(Symbol symbol) {
+  private static boolean isMatch(IdentifierTree tree) {
+    Symbol symbol = ASTHelpers.getSymbol(tree);
+    if (symbol == null) {
+      return false;
+    }
+
     Symbol enclosingSymbol = symbol.getEnclosingElement();
     if (enclosingSymbol == null) {
       return false;