Extend MonoIdentity Refaster rule (#465)

By flagging expressions of the form `mono.flux().next()`.
PicnicSupermarket · Jan 17, 2023 · 82a07fd · 82a07fd
1 parent dec3220
commit 82a07fd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java
@@ -369,7 +369,7 @@ Flux<T> after(Flux<T> flux, T object) {
   static final class MonoIdentity<T> {
     @BeforeTemplate
     Mono<T> before(Mono<T> mono) {
-      return mono.switchIfEmpty(Mono.empty());
+      return Refaster.anyOf(mono.switchIfEmpty(Mono.empty()), mono.flux().next());
     }
 
     @BeforeTemplate

diff --git a/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java b/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java
@@ -116,7 +116,10 @@ ImmutableSet<Flux<String>> testFluxDefaultIfEmpty() {
   }
 
   ImmutableSet<Mono<?>> testMonoIdentity() {
-    return ImmutableSet.of(Mono.just(1).switchIfEmpty(Mono.empty()), Mono.<Void>empty().then());
+    return ImmutableSet.of(
+        Mono.just(1).switchIfEmpty(Mono.empty()),
+        Mono.just(2).flux().next(),
+        Mono.<Void>empty().then());
   }
 
   ImmutableSet<Flux<Integer>> testFluxSwitchIfEmptyOfEmptyPublisher() {

diff --git a/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java b/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java
@@ -121,7 +121,7 @@ ImmutableSet<Flux<String>> testFluxDefaultIfEmpty() {
   }
 
   ImmutableSet<Mono<?>> testMonoIdentity() {
-    return ImmutableSet.of(Mono.just(1), Mono.<Void>empty());
+    return ImmutableSet.of(Mono.just(1), Mono.just(2), Mono.<Void>empty());
   }
 
   ImmutableSet<Flux<Integer>> testFluxSwitchIfEmptyOfEmptyPublisher() {