Resolve some SonarCloud complaints

PicnicSupermarket · Sep 3, 2024 · 69d9d62 · 69d9d62
1 parent 8b22398
commit 69d9d62
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/OptionalRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/OptionalRules.java
@@ -373,7 +373,7 @@ static final class OptionalOrOtherOptional<T> {
     @SuppressWarnings({
       "LexicographicalAnnotationAttributeListing" /* `key-*` entry must remain last. */,
       "NestedOptionals" /* This violation will be rewritten. */,
-      "OptionalOrElse" /* Here `optional2` is a stand-in for expressions that may require computation. */,
+      "OptionalOrElse" /* Parameters represent expressions that may require computation. */,
       "key-to-resolve-AnnotationUseStyle-and-TrailingComment-check-conflict"
     })
     Optional<T> before(Optional<T> optional1, Optional<T> optional2) {

diff --git a/...r-support/src/main/java/tech/picnic/errorprone/refaster/matchers/RequiresComputation.java b/...r-support/src/main/java/tech/picnic/errorprone/refaster/matchers/RequiresComputation.java
@@ -74,10 +74,6 @@ private static boolean matches(ExpressionTree expressionTree) {
       return matches(unary.getExpression());
     }
 
-    if (ASTHelpers.constValue(expressionTree) != null) {
-      return false;
-    }
-
-    return true;
+    return ASTHelpers.constValue(expressionTree) == null;
   }
 }