PSM-1716 Sort

PicnicSupermarket · Dec 30, 2022 · 51ac167 · 51ac167
1 parent 2f9d347
commit 51ac167
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/...rator/src/main/java/tech/picnic/errorprone/plugin/DocumentationGeneratorTaskListener.java b/...rator/src/main/java/tech/picnic/errorprone/plugin/DocumentationGeneratorTaskListener.java
@@ -18,6 +18,7 @@
 import java.io.FileWriter;
 import java.io.IOException;
 import java.nio.file.Files;
+import java.nio.file.InvalidPathException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.Optional;
@@ -38,12 +39,12 @@ final class DocumentationGeneratorTaskListener implements TaskListener {
     this.basePath = path.substring(path.indexOf('=') + 1) + File.separator + "docs";
 
     // XXX: Should we extract this method?
-    Path docsPath = Paths.get(basePath);
     try {
+      Path docsPath = Paths.get(basePath);
       Files.createDirectories(docsPath);
-    } catch (IOException e) {
+    } catch (IOException | InvalidPathException e) {
       throw new IllegalStateException(
-          String.format("Error while creating directory '%s'", docsPath), e);
+          String.format("Error while creating directory with path '%s'", basePath), e);
     }
   }
 

diff --git a/...tor/src/test/java/tech/picnic/errorprone/plugin/DocumentationGeneratorBugPatternTest.java b/...tor/src/test/java/tech/picnic/errorprone/plugin/DocumentationGeneratorBugPatternTest.java
@@ -9,30 +9,31 @@
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
-import java.nio.file.Paths;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.DisabledOnOs;
 import org.junit.jupiter.api.condition.EnabledOnOs;
 import org.junit.jupiter.api.io.TempDir;
 
 final class DocumentationGeneratorBugPatternTest extends DocumentationGeneratorCompilerBasedTest {
-  @Test
   @EnabledOnOs(WINDOWS)
+  @Test
   void wrongPathFailsWindows() {
     wrongPathFails('?');
   }
 
-  @Test
   @DisabledOnOs(WINDOWS)
+  @Test
   void wrongPathFailsOtherOperatingSystems() {
+    // Strictly speaking we are validating here that we cannot write to a RO FS.
     wrongPathFails('/');
   }
 
   private void wrongPathFails(char invalidCharacter) {
     String invalidPath = invalidCharacter + "wrong-path";
     assertThatThrownBy(() -> compile(invalidPath))
         .isInstanceOf(IllegalStateException.class)
-        .hasMessage("Error while creating directory '%s'", Paths.get(invalidPath, "docs"));
+        .hasMessage(
+            "Error while creating directory with path '%s'", invalidPath + File.separator + "docs");
   }
 
   @Test