Remove toImmutableSet() rule

PicnicSupermarket · Aug 14, 2023 · 2f1095a · 2f1095a
1 parent b032f8b
commit 2f1095a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 25 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java
@@ -1328,7 +1328,7 @@ StepVerifier.Step<T> after(StepVerifier.Step<T> step, T object) {
     }
   }
 
-  /** Avoid collecting when verifying only the given element is in the given {@link Flux}. */
+  /** Avoid value collection when verifying that a {@link Flux} emits exactly one value. */
   static final class FluxAsStepVerifierExpectNext<T> {
     @BeforeTemplate
     StepVerifier.Step<ImmutableList<T>> before(Flux<T> flux, T object) {
@@ -1337,13 +1337,6 @@ StepVerifier.Step<ImmutableList<T>> before(Flux<T> flux, T object) {
           .assertNext(list -> assertThat(list).containsExactly(object));
     }
 
-    @BeforeTemplate
-    StepVerifier.Step<ImmutableSet<T>> before2(Flux<T> flux, T object) {
-      return flux.collect(toImmutableSet())
-          .as(StepVerifier::create)
-          .assertNext(set -> assertThat(set).containsExactly(object));
-    }
-
     @AfterTemplate
     StepVerifier.Step<T> after(Flux<T> flux, T object) {
       return flux.as(StepVerifier::create).expectNext(object);

diff --git a/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java b/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java
@@ -1,7 +1,6 @@
 package tech.picnic.errorprone.refasterrules;
 
 import static com.google.common.collect.ImmutableList.toImmutableList;
-import static com.google.common.collect.ImmutableSet.toImmutableSet;
 import static com.google.common.collect.MoreCollectors.toOptional;
 import static java.util.Comparator.reverseOrder;
 import static java.util.function.Function.identity;
@@ -423,18 +422,12 @@ ImmutableSet<StepVerifier.Step<String>> testStepVerifierStepExpectNext() {
         StepVerifier.create(Mono.just("baz")).expectNextMatches("qux"::equals));
   }
 
-  ImmutableSet<Duration> testFluxAsStepVerifierExpectNext() {
-    return ImmutableSet.of(
-        Flux.just(1)
-            .collect(toImmutableList())
-            .as(StepVerifier::create)
-            .assertNext(list -> assertThat(list).containsExactly(2))
-            .verifyComplete(),
-        Flux.just(3)
-            .collect(toImmutableSet())
-            .as(StepVerifier::create)
-            .assertNext(set -> assertThat(set).containsExactly(4))
-            .verifyComplete());
+  Duration testFluxAsStepVerifierExpectNext() {
+    return Flux.just(1)
+        .collect(toImmutableList())
+        .as(StepVerifier::create)
+        .assertNext(list -> assertThat(list).containsExactly(2))
+        .verifyComplete();
   }
 
   Duration testStepVerifierLastStepVerifyComplete() {

diff --git a/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java b/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java
@@ -413,10 +413,8 @@ ImmutableSet<StepVerifier.Step<String>> testStepVerifierStepExpectNext() {
         StepVerifier.create(Mono.just("baz")).expectNext("qux"));
   }
 
-  ImmutableSet<Duration> testFluxAsStepVerifierExpectNext() {
-    return ImmutableSet.of(
-        Flux.just(1).as(StepVerifier::create).expectNext(2).verifyComplete(),
-        Flux.just(3).as(StepVerifier::create).expectNext(4).verifyComplete());
+  Duration testFluxAsStepVerifierExpectNext() {
+    return Flux.just(1).as(StepVerifier::create).expectNext(2).verifyComplete();
   }
 
   Duration testStepVerifierLastStepVerifyComplete() {