Further simplify testing setup

documentation-support/src/main/java/tech/picnic/errorprone/documentation/BugPatternTestExtractor.java

@@ -52,7 +52,6 @@ public BugPatternTestDocumentation extract(ClassTree tree, Context context) {
         scanner.getReplacementTests());
   }
 
-  // XXX: Further improve the heuristics for determining what a BugPattern test is.
   @Override
   public boolean canExtract(ClassTree tree, VisitorState state) {
     String className = tree.getSimpleName().toString();

documentation-support/src/test/resources/tech/picnic/errorprone/documentation/bugpattern-test-documentation-identification-and-replacement.json

@@ -1,12 +1,12 @@
 {
-  "name": "IdentityConversion",
+  "name": "TestChecker",
   "identificationTests": [
-    "public final class A {\n  public void m() {\n    // BUG: Diagnostic contains:\n    Boolean b = Boolean.valueOf(Boolean.FALSE);\n}\n}\n"
+    "class A {}\n"
   ],
   "replacementTests": [
     {
-      "inputLines": "import com.google.common.collect.ImmutableSet;\n\npublic final class A {\n  public void m() {\n    ImmutableSet<Object> set = ImmutableSet.copyOf(ImmutableSet.of());\n  }\n}\n",
-      "outputLines": "import com.google.common.collect.ImmutableSet;\n\npublic final class A {\n  public void m() {\n    ImmutableSet<Object> set = ImmutableSet.of();\n  }\n}\n"
+      "inputLines": "class A {}\n",
+      "outputLines": "class A {}\n"
     }
   ]
-}
+}

documentation-support/src/test/resources/tech/picnic/errorprone/documentation/bugpattern-test-documentation-identification-two-sources.json

@@ -1,8 +1,8 @@
 {
-  "name": "IdentityConversion",
+  "name": "TestChecker",
   "identificationTests": [
-    "public final class B {}\n",
-    "public final class A {}\n"
+    "class B {}\n",
+    "class A {}\n"
   ],
   "replacementTests": []
 }

documentation-support/src/test/resources/tech/picnic/errorprone/documentation/bugpattern-test-documentation-identification.json

@@ -1,7 +1,7 @@
 {
-  "name": "IdentityConversion",
+  "name": "TestChecker",
   "identificationTests": [
-    "public final class A {\n  public void m() {\n    // BUG: Diagnostic contains:\n    Boolean b = Boolean.valueOf(Boolean.FALSE);\n}\n}\n"
+    "class A {}\n"
   ],
   "replacementTests": []
 }

documentation-support/src/test/resources/tech/picnic/errorprone/documentation/bugpattern-test-documentation-minimal.json

@@ -1,5 +1,5 @@
 {
-  "name": "IdentityConversion",
+  "name": "TestChecker",
   "identificationTests": [],
   "replacementTests": []
 }

documentation-support/src/test/resources/tech/picnic/errorprone/documentation/bugpattern-test-documentation-multiple-identification-and-replacement.json

@@ -1,17 +1,17 @@
 {
-  "name": "IdentityConversion",
+  "name": "TestChecker",
   "identificationTests": [
-    "public final class A {\n  public void m() {\n    // BUG: Diagnostic contains:\n    Boolean b = Boolean.valueOf(Boolean.FALSE);\n}\n}\n",
-    "public final class B {\n  public void m() {\n    // BUG: Diagnostic contains:\n    Boolean b = Boolean.valueOf(Boolean.FALSE);\n}\n}\n"
+    "class A {}\n",
+    "class B {}\n"
   ],
   "replacementTests": [
     {
-      "inputLines": "import com.google.common.collect.ImmutableSet;\n\npublic final class A {\n  public void m() {\n    ImmutableSet<Object> set = ImmutableSet.copyOf(ImmutableSet.of());\n  }\n}\n",
-      "outputLines": "import com.google.common.collect.ImmutableSet;\n\npublic final class A {\n  public void m() {\n    ImmutableSet<Object> set = ImmutableSet.of();\n  }\n}\n"
+      "inputLines": "class A {}\n",
+      "outputLines": "class A {}\n"
     },
     {
-      "inputLines": "import com.google.common.collect.ImmutableSet;\n\npublic final class B {\n  public void m() {\n    ImmutableSet<Object> set = ImmutableSet.copyOf(ImmutableSet.of());\n  }\n}\n",
-      "outputLines": "import com.google.common.collect.ImmutableSet;\n\npublic final class B {\n  public void m() {\n    ImmutableSet<Object> set = ImmutableSet.of();\n  }\n}\n"
+      "inputLines": "class B {}\n",
+      "outputLines": "class B {}\n"
     }
   ]
 }

documentation-support/src/test/resources/tech/picnic/errorprone/documentation/bugpattern-test-documentation-replacement-expect-unchanged.json

@@ -1,9 +1,9 @@
 {
-  "name": "IdentityConversion",
+  "name": "TestChecker",
   "identificationTests": [],
   "replacementTests": [
     {
-      "inputLines": "public final class A {}\n",
+      "inputLines": "class A {}\n",
       "outputLines": ""
     }
   ]

documentation-support/src/test/resources/tech/picnic/errorprone/documentation/bugpattern-test-documentation-replacement-two-sources.json

@@ -1,14 +1,14 @@
 {
-  "name": "IdentityConversion",
+  "name": "TestChecker",
   "identificationTests": [],
   "replacementTests": [
     {
-      "inputLines": "public final class B {}\n",
-      "outputLines": "public final class B {}\n"
+      "inputLines": "class B {}\n",
+      "outputLines": "class B {}\n"
     },
     {
-      "inputLines": "public final class A {}\n",
-      "outputLines": "public final class A {}\n"
+      "inputLines": "class A {}\n",
+      "outputLines": "class A {}\n"
     }
   ]
 }

documentation-support/src/test/resources/tech/picnic/errorprone/documentation/bugpattern-test-documentation-replacement.json

@@ -1,10 +1,10 @@
 {
-  "name": "IdentityConversion",
+  "name": "TestChecker",
   "identificationTests": [],
   "replacementTests": [
     {
-      "inputLines": "import com.google.common.collect.ImmutableSet;\n\npublic final class A {\n  public void m() {\n    ImmutableSet<Object> set = ImmutableSet.copyOf(ImmutableSet.of());\n  }\n}\n",
-      "outputLines": "import com.google.common.collect.ImmutableSet;\n\npublic final class A {\n  public void m() {\n    ImmutableSet<Object> set = ImmutableSet.of();\n  }\n}\n"
+      "inputLines": "class A {}\n",
+      "outputLines": "class A {}\n"
     }
   ]
 }