Pair programming

PicnicSupermarket · Jun 12, 2024 · 21878aa · 21878aa
1 parent e6ffb44
commit 21878aa
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/...mental/src/main/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrder.java b/...mental/src/main/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrder.java
@@ -113,6 +113,7 @@ private ImmutableList<TypeMember> getAllTypeMembers(
                       new AutoValue_TypeMemberOrder_TypeMember(
                           member, treeStartPos, state.getEndPosition(member), e)));
 
+      /* XXX: Write explanation about this enum. */
       currentStartPos = Math.max(currentStartPos, state.getEndPosition(member));
     }
     return builder.build();

diff --git a/...c/test/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrderClassTest.java b/...c/test/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrderClassTest.java
@@ -96,7 +96,13 @@ void replacement() {
         .addInputLines(
             "A.java",
             "class A {",
-            "  class Inner {}",
+            "  class Inner {",
+            "    int innerFoo() {",
+            "      return 1;",
+            "    }",
+            "",
+            "    private final int innerBar = 2;",
+            "  }",
             "",
             "  int foo() {",
             "    return foo;",

diff --git a/...rc/test/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrderEnumTest.java b/...rc/test/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrderEnumTest.java
@@ -91,7 +91,8 @@ void replacement() {
         .addInputLines(
             "A.java",
             "enum A {",
-            "  FOO;",
+            "  FOO,",
+            "  BAR;",
             "",
             "  class InnerClass {}",
             "",
@@ -112,13 +113,14 @@ void replacement() {
             "  }",
             "",
             "  final int baz = 2;",
-            "  static final int BAR = 1;",
+            "  static final int BAZ = 1;",
             "}")
         .addOutputLines(
             "A.java",
             "enum A {",
-            "  FOO;",
-            "  static final int BAR = 1;",
+            "  FOO,",
+            "  BAR;",
+            "  static final int BAZ = 1;",
             "",
             "  final int baz = 2;",
             "",