Introduce MonoJustOrEmptyOptional Refaster rule (#563)

While there, rename two other rules.
PicnicSupermarket · Apr 5, 2023 · 0fefb69 · 0fefb69
1 parent 64f9d6b
commit 0fefb69
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 6 deletions.
diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java
@@ -94,7 +94,7 @@ Mono<T> after(T value) {
   }
 
   /** Prefer {@link Mono#justOrEmpty(Object)} over more contrived alternatives. */
-  static final class MonoJustOrEmpty<@Nullable T> {
+  static final class MonoJustOrEmptyObject<@Nullable T> {
     @BeforeTemplate
     Mono<T> before(T value) {
       return Mono.justOrEmpty(Optional.ofNullable(value));
@@ -107,9 +107,25 @@ Mono<T> after(T value) {
   }
 
   /** Prefer {@link Mono#justOrEmpty(Optional)} over more verbose alternatives. */
+  static final class MonoJustOrEmptyOptional<T> {
+    @BeforeTemplate
+    Mono<T> before(Optional<T> optional) {
+      return Mono.just(optional).filter(Optional::isPresent).map(Optional::orElseThrow);
+    }
+
+    @AfterTemplate
+    Mono<T> after(Optional<T> optional) {
+      return Mono.justOrEmpty(optional);
+    }
+  }
+
+  /**
+   * Prefer {@link Mono#defer(Supplier) deferring} {@link Mono#justOrEmpty(Optional)} over more
+   * verbose alternatives.
+   */
   // XXX: If `optional` is a constant and effectively-final expression then the `Mono.defer` can be
   // dropped. Should look into Refaster support for identifying this.
-  static final class MonoFromOptional<T> {
+  static final class MonoDeferMonoJustOrEmpty<T> {
     @BeforeTemplate
     @SuppressWarnings(
         "MonoFromSupplier" /* `optional` may match a checked exception-throwing expression. */)

diff --git a/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java b/...ontrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestInput.java
@@ -60,11 +60,15 @@ Mono<Integer> testMonoJust() {
     return Mono.justOrEmpty(Optional.of(1));
   }
 
-  Mono<Integer> testMonoJustOrEmpty() {
+  Mono<Integer> testMonoJustOrEmptyObject() {
     return Mono.justOrEmpty(Optional.ofNullable(1));
   }
 
-  ImmutableSet<Mono<Integer>> testMonoFromOptional() {
+  Mono<Integer> testMonoJustOrEmptyOptional() {
+    return Mono.just(Optional.of(1)).filter(Optional::isPresent).map(Optional::orElseThrow);
+  }
+
+  ImmutableSet<Mono<Integer>> testMonoDeferMonoJustOrEmpty() {
     return ImmutableSet.of(
         Mono.fromCallable(() -> Optional.of(1).orElse(null)),
         Mono.fromSupplier(() -> Optional.of(2).orElse(null)));

diff --git a/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java b/...ntrib/src/test/resources/tech/picnic/errorprone/refasterrules/ReactorRulesTestOutput.java
@@ -62,11 +62,15 @@ Mono<Integer> testMonoJust() {
     return Mono.just(1);
   }
 
-  Mono<Integer> testMonoJustOrEmpty() {
+  Mono<Integer> testMonoJustOrEmptyObject() {
     return Mono.justOrEmpty(1);
   }
 
-  ImmutableSet<Mono<Integer>> testMonoFromOptional() {
+  Mono<Integer> testMonoJustOrEmptyOptional() {
+    return Mono.justOrEmpty(Optional.of(1));
+  }
+
+  ImmutableSet<Mono<Integer>> testMonoDeferMonoJustOrEmpty() {
     return ImmutableSet.of(
         Mono.defer(() -> Mono.justOrEmpty(Optional.of(1))),
         Mono.defer(() -> Mono.justOrEmpty(Optional.of(2))));