fixup! Merge fixes of inner type decls, enable sorting nested types i…

…n one-go
PicnicSupermarket · Dec 7, 2024 · 0bc5f94 · 0bc5f94
1 parent 47e27eb
commit 0bc5f94
Showing 1 changed file with 4 additions and 14 deletions.
diff --git a/...mental/src/main/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrder.java b/...mental/src/main/java/tech/picnic/errorprone/experimental/bugpatterns/TypeMemberOrder.java
@@ -89,15 +89,7 @@ public Description matchCompilationUnit(
     return describeMatch(compilationUnitTree, suggestedFix);
   }
 
-  /**
-   * Matches a class.
-   *
-   * @param tree xxx
-   * @param state xxx
-   * @param compilationUnit xxx
-   * @return xxx
-   */
-  public SuggestedFix matchClass(
+  private SuggestedFix matchClass(
       ClassTree tree, VisitorState state, JCTree.JCCompilationUnit compilationUnit) {
     Kind treeKind = tree.getKind();
     if (treeKind != Kind.CLASS && treeKind != Kind.INTERFACE && treeKind != Kind.ENUM) {
@@ -267,9 +259,7 @@ private static SuggestedFix sortTypeMembers(
               return original.equals(replacement)
                   ? SuggestedFix.emptyFix()
                   : SuggestedFix.replace(
-                      original.startPosition(),
-                      original.endPosition(),
-                      replacementSource.toString());
+                      original.startPosition(), original.endPosition(), replacementSource);
             })
         .reduce(SuggestedFix.builder(), SuggestedFix.Builder::merge, SuggestedFix.Builder::merge)
         .build();
@@ -296,11 +286,11 @@ abstract static class TypeMember implements Comparable<TypeMember> {
 
     abstract int endPosition();
 
-    abstract Integer preferredOrdinal();
+    abstract int preferredOrdinal();
 
     @Override
     public int compareTo(TypeMemberOrder.TypeMember o) {
-      return preferredOrdinal().compareTo(o.preferredOrdinal());
+      return Integer.compare(preferredOrdinal(), o.preferredOrdinal());
     }
   }
 }