Set the fill_sampling_holes parameter to True #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eholum
reviewed
Dec 20, 2023
| @@ -201,6 +201,11 @@ def launch_setup(context, *args, **kwargs): | |||
| ("depth/camera_info", "depth/camera_info"), | |||
| ("depth/image_rect", "depth/image_raw"), | |||
| ], | |||
| parameters=[ | |||
There was a problem hiding this comment.
Might be worth adding a comment that just says exactly what you have in the description...
Suggested change
| parameters=[ | |
| # Due to the resolution disparity between the depth images and the rgb images from the embedded DH410 rgbd camera on the gen3 kinova, | |
| # when the depth images are registered in the color image frame, many sampling holes occur. | |
| # Turning on the fill_sampling_holes parameter spreads the lower resolution depth data out across the | |
| # registered image so there are no sampling holes. | |
| parameters=[ |
dyackzan
force-pushed
the
set-fill-sampling-holes-param
branch
from
b592e50 to
81b60ee
Compare
Due to the resolution disparity between the depth images and the rgb images from the embedded D410 rgbd camera on the gen3 kinova, when the depth images are registered in the color image frame, many holes occur in the registered depth data. Turning on fill_upsampling_holes spreads the lower resolution depth data out across the registered image to eliminate these holes.
dyackzan
force-pushed
the
set-fill-sampling-holes-param
branch
from
81b60ee to
1c2d693
Compare
eholum
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the resolution disparity between the depth images and the rgb images from the embedded DH410 rgbd camera on the gen3 kinova, when the depth images are registered in the color image frame, many sampling holes occur. Turning on the fill_sampling_holes parameter spreads the lower resolution depth data out across the registered image so there are no sampling holes.