Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure positive values are returned from read unless at end of file. #165

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Ensure positive values are returned from read unless at end of file. #165

merged 1 commit into from
Nov 29, 2021
+1 −1

Conversation

gugrim
Copy link
Contributor

@gugrim gugrim commented Nov 27, 2021

Fixes issue #164.

@FDelporte FDelporte linked an issue Nov 29, 2021 that may be closed by this pull request
Mock plugin single byte read returns -1 for 0xff. #164
Closed
@FDelporte
Copy link
Member

Thanks for the bug report and fix!! Always nice to get such feedback!

@FDelporte
Copy link
Member

@eitch this matches e.g. LinuxFX I2C provider?

@eitch
Copy link
Member

eitch commented Nov 29, 2021

@gugrim thanks for the fix!

@FDelporte This does not affect the LinuxFS I2C provider.

@eitch eitch merged commit 00f486f into Pi4J:develop Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FDelporte FDelporte FDelporte approved these changes

Assignees

@eitch eitch

@FDelporte FDelporte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mock plugin single byte read returns -1 for 0xff.
3 participants
@gugrim @FDelporte @eitch