-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent DocumentFragment from causing internal PHP error by using append() #454
Conversation
PHPUnit is failing because it's trying to run PHPUnit 11 which requires PHP >= 8.2, but that's not what it says in the composer.lock (or even componser.json). I will need to upgrade the actions runner as described here: php-actions/phpunit#54 |
…ning text nodes Credits for test: PhpGt/Dom#454.
@g105b PHP core maintainer here. I fixed this here: php/php-src#14206 |
@nielsdos hey, thank you for your message. I will submit an upstream issue whenever something like this comes up, but I've never felt confident to do it. I see now that PHP has an issue tracker on Github, so I guess it's just as simple as opening an issue there? That's a lot LOT easier than before, when it was on bugs.php.net. Thanks for the fix, I'll test it and see if I can remove more of the workarounds in this library. |
Yep it's just a matter of opening a GH issue. It doesn't even have to be much, just code is enough. |
…ning text nodes Credits for test: PhpGt/Dom#454. Closes GH-14206.
This is some weird libxml behaviour. I'm going to put in an upstream bug fix at some point, but one of the purposes of this library is to patch this kind of weird behaviour. All tests passing now.
Closes #453