331: Add warning before saving "both hands" for 1 handed signs #368
Conversation
| @@ -302,18 +325,18 @@ def validate_and_save(self, addanother=False, closedialog=False): | |||
| modulevalid, modulemessage = self.module_widget.validity_check() | |||
|
|
|||
| messagestring = "" | |||
| if not (articulatorsvalid and timingvalid): | |||
| if not articulatorsvalid: | |||
There was a problem hiding this comment.
ok so this was because I originally thought I needed to single out articulatorsvalid...
However, I think what I have now is easier to read as it has less conditionals & I've tested it still gives the same error messages.
But if we prefer the old way, I'm completely fine to change it
|
|
||
| # validate hand selection | ||
| articulatorsvalid, articulators = self.validate_articulators() | ||
| # if the default is "1h" and we have both hands selected... | ||
| if articulators[0] == HAND and self.defaultHandArticulator == "1h" and articulators[1][1] and articulators[1][2]: | ||
| msgBox = QMessageBox() |
There was a problem hiding this comment.
not sure if there's a cleaner way to make a QMessageBox with custom buttons :D
| if HAND in incl_articulators and self.parent().sign.signtype: | ||
| # set default articulators | ||
| handSelection = self.parent().sign.signtype.specslist[0][0] | ||
| if "1h" in handSelection: |
There was a problem hiding this comment.
If we're ok with this logic, I thought of making 1h and 2h a constant string in the constants file. Not sure if that would be helpful elsewhere though?
There was a problem hiding this comment.
and we're not doing an exact match bc some of the options have more to the string than just 1h (which should be irrelevant for my use case)
|
Side note: going through the code is a bit of a pain due to the clustering of UI logic with business logic. If I'm still here after Beta release, can I try out some ways to separate the two? |
Harukaichii
force-pushed
the
331-add-dependency-btwn-signtype-ind-mod
branch
from
e74b791 to
db26c36
Compare
…-associated-relation-modules finish refactoring named arguments modified in PR #368
includephrasereference -- doesn't seem like it is being used?Part1.mov
Part2.mov
Note: If you toggle between the options it will reset
2024-08-09.8.03.57.mov