Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ə back to PCT #740

Closed
stannam opened this issue Jun 9, 2020 · 2 comments
Closed

Add ə back to PCT #740

stannam opened this issue Jun 9, 2020 · 2 comments
Assignees
@stannam
Labels
enhancement Lower Priority

Comments

@stannam
Copy link
Member

stannam commented Jun 9, 2020

Make this pretty PCT logo available on Mac.
image

cf.
https://doc.qt.io/qt-5/appicon.html#setting-the-application-icon-on-os-x
https://www.learnpyqt.com/courses/adanced-ui-features/system-tray-mac-menu-bar-applications-pyqt/
@stannam stannam self-assigned this Jun 9, 2020
@kchall kchall changed the title Have ə back to PCT Add ə back to PCT Jul 17, 2020
stannam added a commit that referenced this issue Aug 11, 2020
@stannam
schwa icon for mac executable (#740)
7b122de 
Mac uses a .icns file for the app icon. The PCT repository *does* have the .icns file intended to be used on Mac, but for unclear reasons, this file was not referenced in the Pyinstaller configuration file (i.e., pct.spec). This commit modifies .spec file and also copies the .icns file to a more reasonable folder.
@stannam
Copy link
Member Author

stannam commented Aug 12, 2020

Plus, add a ↔ icon to the segment pair table widget.

stannam added a commit that referenced this issue Aug 12, 2020
@stannam
An icon for the switch segment button (#740)
af1c9ee 
For the 'segment pair table' widget. The widget is used when selecting a pair of segments in ProD, FL, and Kullback-Leibler.
The button that flips the order of two segments is supposed to have a ↔ shaped icon (./resources/object-flip-horizontal.png). However, the image does not load except for the Linux machine.
Instead, this commit makes the button does not rely on an external image file and uses an icon provided with the PyQt5 package itself, so the image on the button should appear on any machine.
@stannam stannam closed this as completed Aug 16, 2020
@stannam stannam reopened this Aug 19, 2020
@stannam
Copy link
Member Author

stannam commented Aug 19, 2020

On macOS, while clicking the 🔄 icon actually flips the segment pair, the result does not show up.
This seems to be a known issue. i.e., on psgui.py jsmackie commented the following:
# for some reason, adding a new row isn't working. a blank row is added on screen, no cell contents.
# after closing and re-opening, the row is correctly filled (meaning self.saved is properly updated)
# to solve this problem, update the entire table from scratch, which seems to work

@stannam stannam mentioned this issue Sep 2, 2020
Closed
stannam added a commit that referenced this issue Sep 14, 2020
@stannam
Flip icon on MacOS re: issue #740
2f6b45a 
Force adding and deleting a row.
@stannam stannam closed this as completed Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stannam stannam

Labels
enhancement Lower Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stannam