feat: add .env example #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brent-hoover
commented
Jun 26, 2024
| @@ -7,6 +7,7 @@ import { SampleService } from './services/sample-service'; | |||
| import KafkaEventService from '../../event/kafka-event-service'; | |||
| import { Queue, Job } from 'bullmq'; | |||
| import logger from '../../config/logger.ts'; | |||
| import env from '../../config/config.ts'; | |||
There was a problem hiding this comment.
Not sure how this would work in a real plugin context. I think we handled this in RC with just each plugin having it's own config. Realistically you should not need to know the connection parameters to just create queues and workers.
Not solving this problem in this PR.
aldeed
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30