Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font smoothing settings #943

Merged
merged 46 commits into from
Jun 28, 2019
Merged

Conversation

ImperatorS79
Copy link
Contributor

@ImperatorS79 ImperatorS79 commented May 15, 2019

I got this each time I try to change the setting No more issues!:

Exception in thread "JavaFX Application Thread" engines.wine.plugins.regedit:17 TypeError: Cannot read property "getClass" from undefined
        at jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)
        at jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:213)
        at jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:185)
        at jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.typeError(ECMAErrors.java:172)
        at jdk.scripting.nashorn/jdk.nashorn.internal.runtime.Undefined.get(Undefined.java:161)
        at jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$353$359A$\^eval\_.regedit#patch(engines.wine.plugins.regedit:17)
        at jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$352$1484AI$\^eval\_.setOption(engines.wine.settings.fonts_smoothing:85)
        at jdk.nashorn.javaadapters.org_phoenicis_engines_EngineSetting.setOption(Unknown Source)
        at org.phoenicis.javafx.components.container.skin.ContainerEngineSettingsPanelSkin.lambda$updateEngineSettingsGrid$2(ContainerEngineSettingsPanelSkin.java:92)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:428)
        at java.base/java.security.AccessController.doPrivileged(Native Method)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:427)
        at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
        at javafx.graphics/com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
        at javafx.graphics/com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
        at java.base/java.lang.Thread.run(Thread.java:834)

Any idea ?

Fix #912.

Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master
updated Hearthstone (download application directly) (PhoenicisOrg#383)
@ImperatorS79
Copy link
Contributor Author

Ok, it works now ^^.
@Kreyren Can you check this works ?

@plata
Copy link
Collaborator

plata commented Jun 4, 2019

This is supposed to fix #912, correct?

@ImperatorS79
Copy link
Contributor Author

Yep

@Kreyren
Copy link
Contributor

Kreyren commented Jun 4, 2019

@ImperatorS79 didn't get notification, can't check since i'm blocked by #881

@plata
Copy link
Collaborator

plata commented Jun 4, 2019

@ImperatorS79 can you add this to the PR description then such that it will get closed automatically one this is merged?

@madoar
Copy link
Collaborator

madoar commented Jun 22, 2019

@ImperatorS79 does the error still occur with GraalJS?

@ImperatorS79
Copy link
Contributor Author

I fixed it some times after opening the PR ^^.

@plata
Copy link
Collaborator

plata commented Jun 22, 2019

So ready for review? (The pr description still says that there is an issue).

@ImperatorS79
Copy link
Contributor Author

Yes ready for review

Copy link
Collaborator

@plata plata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will clash with @madoar work. Please coordinate with him.

Engines/Wine/Plugins/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Plugins/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Settings/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Settings/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Plugins/Font smoothing/script.js Outdated Show resolved Hide resolved
FontSmoothingOrientation = "1";
}

var regeditFileContent =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the ideal try to introduce template (multiline) strings in our scripts! Such strings make strings like the following much easier readable. For more details see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals

Engines/Wine/Settings/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Plugins/Font smoothing/script.js Outdated Show resolved Hide resolved
@ImperatorS79
Copy link
Contributor Author

Ready to merge.

Engines/Wine/Plugins/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Plugins/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Settings/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Settings/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Plugins/Font smoothing/script.js Outdated Show resolved Hide resolved
Engines/Wine/Settings/Font smoothing/script.js Outdated Show resolved Hide resolved
@ImperatorS79 ImperatorS79 merged commit bba2f5b into PhoenicisOrg:master Jun 28, 2019
@ImperatorS79 ImperatorS79 deleted the FontSmooth branch August 24, 2019 16:33
petermetz pushed a commit to petermetz/scripts that referenced this pull request Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FontsSmoothRGB verb
4 participants