-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font smoothing settings #943
Conversation
Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master
updated Hearthstone (download application directly) (PhoenicisOrg#383)
Merge master
Merge recent commits
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge master
Merge Master
Merge master
Ok, it works now ^^. |
This is supposed to fix #912, correct? |
Yep |
@ImperatorS79 didn't get notification, can't check since i'm blocked by #881 |
@ImperatorS79 can you add this to the PR description then such that it will get closed automatically one this is merged? |
@ImperatorS79 does the error still occur with GraalJS? |
I fixed it some times after opening the PR ^^. |
So ready for review? (The pr description still says that there is an issue). |
Yes ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will clash with @madoar work. Please coordinate with him.
FontSmoothingOrientation = "1"; | ||
} | ||
|
||
var regeditFileContent = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the ideal try to introduce template (multiline) strings in our scripts! Such strings make strings like the following much easier readable. For more details see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
Ready to merge. |
I got this each time I try to change the settingNo more issues!:Any idea ?
Fix #912.