Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DXVK to always use the latest release #660

Merged
merged 16 commits into from
Oct 18, 2018

Conversation

Zemogiter
Copy link
Contributor

No description provided.

@ImperatorS79
Copy link
Contributor

It's possible to retrieve latest dxvk version from this file -> https://github.com/doitsujin/dxvk/blob/master/RELEASE, but i do not know how to do this from the script.

Then, by avoiding checksum, nothing more to update !

@Zemogiter
Copy link
Contributor Author

That would require reading the string from RELEASE file and inserting it into the download URL. We could simply download that file to a tmp folder. Not sure how to read strings from files in Javascript though.

@plata
Copy link
Collaborator

plata commented Jul 12, 2018

Atempting to make the script use version number stored on remote server instead of manually updating it when it changes.
@plata plata changed the title Update DXVK to 0.61 Update DXVK to always use the latest release Jul 12, 2018
@Zemogiter
Copy link
Contributor Author

Ready for review

Removing the checksum
@Zemogiter
Copy link
Contributor Author

Ready for review.

Engines/Wine/Verbs/DXVK/script.js Outdated Show resolved Hide resolved
@mihawk90
Copy link

Same as for the VK9 PR, it would be nice if the user (or script for that matter) could choose the specific version to use. Sometimes there are regressions, especially in early projects like this.

Engines/Wine/Verbs/DXVK/script.js Outdated Show resolved Hide resolved
Engines/Wine/Verbs/DXVK/script.js Outdated Show resolved Hide resolved
@plata
Copy link
Collaborator

plata commented Oct 17, 2018

Please fix Codacy.

Fixed the ridicolous codacy errors
@plata plata merged commit ee666ce into PhoenicisOrg:master Oct 18, 2018
@Zemogiter Zemogiter deleted the DXVK-fix branch October 18, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants