Update Internet Explorer 7.0 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff looks strange somehow. |
Attempting to fix trailing space error and tempFile not being defined anywhere.
plata
requested changes
May 30, 2018
Removed distribution() and architecture() parameters.
Fixes for the implementation of PhoenicisOrg#627
plata
requested changes
May 30, 2018
Removed .luna() and indentation fixes.
Another indentation fixes.
|
Can you install it to see if it works? |
|
It gives me this error regardless of repo priority (meaning that this error is likey not related to this script): |
|
Try to replace l.13 by: var application = appsManager.getApplication([TYPE_ID, CATEGORY_ID, APPLICATION_ID])The script for IE6 has the same issue. |
|
Now the script starts but right after clicking on "Next" it crashes with this error: We might have to convert it from custom script to OnlineScript. |
|
This is happening because version, distribution and architecture must be given in the var wine = new Wine()
.wizard(setupWizard)
.prefix("InternetExplorer7", "upstream", "x86", LATEST_STABLE_VERSION)
.create();
wine.run("iexplore", ["-unregserver"], null, false, true);
wine.overrideDLL()
.set("native,builtin", [
"iexplore.exe", "itircl", "itss", "jscript", "mshtml", "msimtf", "shdoclc", "shdocvw", "shlwapi", "urlmon", "xmllite"
])
.set("builtin", ["updspapi"])
.do(); |
Specified parameters in .prefix
|
Ready for review but now throws up a diffirent error: |
|
This should be fixed by var application = appsManager.getApplication([TYPE_ID, CATEGORY_ID, APPLICATION_ID])Did you revert that again? |
|
I think I might accidentally do that. But with that change the script starts but it crashes with this: The local script for IE7 I'm using contains both |
|
You must remove .version(LATEST_STABLE_VERSION)The version is already specified in the |
|
Did that now the script runs but once prefix is created the script crashes with this error despite the fact that this location exist |
|
Can you figure out where exactly this happens? Otherwise I guess I'll have to try myself because I don't see this issue currently. |
|
It happens randomly. I tried the script again just a moment ago and this time the error appears right after clicking on "Next" in the script introduction. Removing the wineprefix and trying again solves this error but shortly after IE language selection the script crashes with the following error: Strangely enough, this does not stop the IE instalation. However the IE installator shows an error that says "Internet Explorer 7 is not supported in this OS". I'm sending the phoenicis.log file UPDATE: Today wine 3.10 was released and on the list of fixed bugs is |
|
Do we still need this PR? Cause I just tried to run it and got this error: |
|
If the script doesn't work, we should fix it. So yes. I think var application = appsManager.getApplication(["Applications", "Internet", "Internet Explorer 7.0"]);should be var application = appsManager.getApplication(["applications", "internet", "internet_explorer_7_0"]); |
Changes the parameters in application var.
Changed the wine variable to match the example on https://phoenicisorg.github.io/scripts/Develop/script-js/#custominstallerscript
|
The latest version of the script gives me this error: Also the link in push description is wrong. This is the correct one: |
|
I've edited the script online. Not quite sure which link you're talking about. Can you provide a PR with the fix? |
|
It happen when the script reaches this line: |
|
Ah ok. Try wine.run(setupFile, [], null, false, true);
wine.wait(); |
|
That fixes the |
|
I don't know. The syntax looks correct. Have you tried "sp3" or maybe "vista"? |
|
I've tried winxp and sp3 same result. Just tried vista and it gave me the "system is not compatible" message. |
|
Mh. Did it set the Windows version correctly? Can you check in the registry? |
|
I found this in Nothing about service pack |
|
Is it also there if you check with |
|
Yes. No mention about service pack there also. |
|
Please upload the current state you have. Can you try if the winetricks installation works with Wine 3.0.2? If it does, we can use it as an example. |
Changed wine version to 3.0.2 for testing
|
I think I found something. |
|
Switching to 3.0.2 didn't solve the issue. But I found something strange. In |
|
Yes, we have a bug in the Windows version plugin. I'm fixing it right now. |
|
Pull request is online. Have a look if it helps. |
|
I've applied your fix to my local repo and now I get different message: I've removed the wineprefix but still getting this error. |
|
Add this before line 34: // delete existing IE, otherwise installer will abort with "newer IE installed"
remove(wine.prefixDirectory() + "/drive_c/" + wine.programFiles() + "/Internet Explorer/iexplore.exe"); |
Attempting to fix the "newer version installed" error.
|
Did that, still getting the same error. |
|
Strange. I tried locally and it worked. I will upload what I have. |
|
On appDB there is an entry form 2017 using wine 1.8.7 that says it works. I am going to try that wine version. |
|
Try the current state. It should run. |
|
Thanks. The script no longer throws any errors and installation works. But when clicking on "Run" in "Library" tab, nothing happens. |
|
I don't know what the problem is but as the installation works, I will merge this so anyone who cares can provide a fix. |
plata
approved these changes
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.