Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added output to update_translations.py #495

Merged
merged 1 commit into from
Mar 2, 2018
Merged

added output to update_translations.py #495

merged 1 commit into from
Mar 2, 2018

Conversation

plata
Copy link
Collaborator

@plata plata commented Mar 2, 2018

This should give us an idea about what's going on in Travis.

Copy link
Collaborator

@madoar madoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding the \n behind the strings you want to print.

@plata
Copy link
Collaborator Author

plata commented Mar 2, 2018

Doesn't work (at least not easily). I would have to find the last run of the loop.

@plata plata merged commit f90d610 into PhoenicisOrg:master Mar 2, 2018
@plata plata deleted the update-translations-output branch March 2, 2018 17:36
@madoar
Copy link
Collaborator

madoar commented Mar 2, 2018

why not add an additional print "\n" behind the loop?

@plata
Copy link
Collaborator Author

plata commented Mar 2, 2018

I could do that but where's the difference compared to how it's now?

@madoar
Copy link
Collaborator

madoar commented Mar 2, 2018

It's easier readable. I also believe that it may be a better idea to print one language in each row.
This is especially a good idea, if we have a lot of supported languages.

@plata
Copy link
Collaborator Author

plata commented Mar 2, 2018

The languages are already printed one per row. You can check the output in Travis.

@madoar
Copy link
Collaborator

madoar commented Mar 2, 2018

Yes I just saw it.
I guess one or more of the commands you open a subprocess for isn't executed correctly.
Is it possible to force an output for them?

@plata
Copy link
Collaborator Author

plata commented Mar 2, 2018

I tried but it's not really helpful (the pipe is eating all the info). What we could to is split the command and try every portion until we find the issue. But I don't really want to do this on master.

@plata
Copy link
Collaborator Author

plata commented Mar 2, 2018

It must be something with the xgettext. We could see already that the msgmerge and msgcat is working.

@madoar
Copy link
Collaborator

madoar commented Mar 2, 2018

You could try to setup travis for your fork? (I guess this should work)

@plata
Copy link
Collaborator Author

plata commented Mar 2, 2018

Or just a pull request to play around until it works?

@madoar
Copy link
Collaborator

madoar commented Mar 2, 2018

Whatever works I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants