Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure Codacy #474

Merged
merged 5 commits into from
Feb 14, 2018
Merged

configure Codacy #474

merged 5 commits into from
Feb 14, 2018

Conversation

plata
Copy link
Collaborator

@plata plata commented Feb 14, 2018

No description provided.

@plata
Copy link
Collaborator Author

plata commented Feb 14, 2018

Not sure if the globals config works like this. If it does, I will add the other stuff.

@plata
Copy link
Collaborator Author

plata commented Feb 14, 2018

According to https://support.codacy.com/hc/en-us/articles/207994335-Code-Patterns Codacy should use the .eslintrc.yml but it doesn't seem to work (Codacy says: "We could not find a ESLint configuration file in your project root"). Any ideas?

@plata plata changed the title added .codacy.yml configure Codacy Feb 14, 2018
@madoar
Copy link
Collaborator

madoar commented Feb 14, 2018

Does it work now after your commits?

@plata
Copy link
Collaborator Author

plata commented Feb 14, 2018

No. It still shows e.g. 'include' is not defined and doesn't seem to recognize the ESLint configuration (see Your rules configuration).

@madoar
Copy link
Collaborator

madoar commented Feb 14, 2018

I'm not sure, but I guess it's possible, that codacy hasn't used your changes yet, because they are done inside a PR.
If you take a look at the top left you'll see that the master branch is selected, maybe that's the reason?

Copy link
Collaborator

@madoar madoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how the LATEST_..._VERSION attributes are used by eslint, but I think we can merge this

@plata
Copy link
Collaborator Author

plata commented Feb 14, 2018

Ok. Let's try if you're right.

@plata plata merged commit 6aff658 into PhoenicisOrg:master Feb 14, 2018
@plata plata deleted the codacy-conf branch February 14, 2018 13:53
@plata
Copy link
Collaborator Author

plata commented Feb 14, 2018

Seems to be still the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants