Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Oldwares #466

Merged
merged 1 commit into from
Dec 14, 2017
Merged

added Oldwares #466

merged 1 commit into from
Dec 14, 2017

Conversation

plata
Copy link
Collaborator

@plata plata commented Dec 13, 2017

Move all applications from Oldwares to the Scripts repository. There's really no good reason to separate them. Additionally, the maintenance is a lot easier if all scripts are located in one repository.

@qparis
Copy link
Member

qparis commented Dec 13, 2017

I think there are still some reasons to separate them:

  • Potentially, we could have hundred of oldware and it could dilute real games
  • AFAIK, the legal aspect of the use of oldware depends on your contry.
  • Having two default repositories ensure that we always test this behavior

@plata
Copy link
Collaborator Author

plata commented Dec 13, 2017

  • I don't see how a game from Oldwares is not a real game. In my opinion, Prince of Persia is at least as much a real game as Druid Soccer is. Yes, the list of available applications might increase. But the same will happen without Oldwares as well. If this should be a problem, we must think about better search/filter possibilities.
  • How can there be a legal aspect when we provide scripts? If there is a problem, we have the same issue with any LocalInstallerScript.
  • In fact, that didn't even happen. Before I merged the 4 lvl JS namespace some minutes ago, none of the scripts in Oldwares did show up in the applications.

@madoar
Copy link
Collaborator

madoar commented Dec 13, 2017

I agree with @plata.
I don't think that the official repository organization should have more than one repository for scripts, because this could confuse the users.
In addition the name Oldwares isn't really descriptive about the scripts the repository contains.

About the legal aspect:
I don't think splitting the scripts in multiple repositories has any significant effects on this.
I mean, if some legal person doesn't want us to provide a script for an application we will be forced to remove it, I don't think it makes any difference then how many script repositories we have.

@qparis
Copy link
Member

qparis commented Dec 13, 2017

All right

@plata plata merged commit eac1dca into PhoenicisOrg:master Dec 14, 2017
@plata plata deleted the oldware branch December 14, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants