show miniature when installing an application #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madoar
reviewed
Aug 26, 2017
| var setupWizard = SetupWizard(this._name); | ||
| var appsManager = Bean("repositoryManager"); | ||
| var application = appsManager.getApplication([this._type, this._category, this._name]); | ||
| var setupWizard = SetupWizardWithMiniature(this._name, application.getMainMiniature().get()); |
There was a problem hiding this comment.
I think calling get() is dangerous here. We can't be sure, that a script provides a main miniature. If this is not the case this line will throw an exception.
There was a problem hiding this comment.
It's not true. I've just tried it. The only thing that happens is that the default miniature is used.
There was a problem hiding this comment.
This makes no sense.
If no main miniature exists for an application Optional.empty() is returned.
If you call get() on Optional.empty, then new NoSuchElementException("No value present") will be thrown.
There was a problem hiding this comment.
Now I have it. Don't know. Must have done something wrong.
madoar
approved these changes
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires PhoenicisOrg/phoenicis#1061