Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DOOM (2016) #359

Merged
merged 2 commits into from
Aug 22, 2017
Merged

Added DOOM (2016) #359

merged 2 commits into from
Aug 22, 2017

Conversation

ImperatorS79
Copy link
Contributor

I do not own the game but it has a platinum rating on the appdb

Copy link
Collaborator

@plata plata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you cannot test it, please set it at least to "Testing". In general, I believe that we should not add scripts we cannot test at all because they will most likely not work in the end for whatever reason.

@madoar
Copy link
Collaborator

madoar commented Aug 21, 2017

The problem with setting possibly working scripts to testing is, how to differentiate them from script that are set to testing because they are not working scripts (the league of legends script belongs in this category)?

@plata
Copy link
Collaborator

plata commented Aug 21, 2017

I don't know. But not using "testing" for untested scripts doesn't make sense either.

@madoar
Copy link
Collaborator

madoar commented Aug 21, 2017

That's right but we should add some kind of note field, where we can give a short description of the working state of the script. Ideally this field should be shown during the installation wizard.

@plata
Copy link
Collaborator

plata commented Aug 21, 2017

That's not a bad idea. Can you open a new issue for this?

@madoar
Copy link
Collaborator

madoar commented Aug 21, 2017

Yes, see #361

@plata plata merged commit e0ac28c into PhoenicisOrg:master Aug 22, 2017
@ImperatorS79 ImperatorS79 deleted the DOOM branch August 22, 2017 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants