Udpated Star Wars Empire At War #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing logo
|
I'm not sure I see the relation between the commit and your comment "Fix missing logo"? |
|
When the names in application.json and script.js differ, the logo is missing in the library tab |
|
This looks like a bug to me, that the logo is missing in the library tab, if the names differ. |
|
Isn't it #269 ? |
|
You're right. Seems like I forgot that we had this issue before... |
madoar
approved these changes
Aug 19, 2017
|
This should have been "updated" not "udpated" ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing logo