Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated SteamScript to cache path of manifest file #341

Merged
merged 1 commit into from
Aug 19, 2017
Merged

updated SteamScript to cache path of manifest file #341

merged 1 commit into from
Aug 19, 2017

Conversation

plata
Copy link
Collaborator

@plata plata commented Aug 18, 2017

The path of the manifest file will not change during the installation of a Steam application. Therefore it is sufficient to calculate it once.

fixes #331

The path of the manifest file will not change during the installation of a Steam application. Therefore it is sufficient to calculate it once.
@madoar
Copy link
Collaborator

madoar commented Aug 18, 2017

Are you sure this is such a large problem? I'm asking because this is simple string arithmetics, we're doing here, nothing more.

@plata
Copy link
Collaborator Author

plata commented Aug 19, 2017

The problem is that it uses ProcessBuilder to get the programFiles. For some reason this seems to cause #331. So: No, I don't think that it is a large problem but the solution solves #331 and saves some computation time (which I would see as a nice side effect rather than the main purpose of this PR).

@plata plata merged commit 7d73400 into PhoenicisOrg:master Aug 19, 2017
@plata plata deleted the steam-cache-manifest branch August 19, 2017 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wine.run throws "error=7, Argument list too long"
2 participants