-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added possibility to configure new shortcut when creating it #1069
Conversation
Build finished. |
Jenkins Build Success +1 |
I think it would be more intuitive if we add a red background or border to the textfields that are wrong. |
Build finished. |
Jenkins Build Success +1 |
@@ -602,6 +602,10 @@ | |||
-fx-font-family: "Roboto Light"; | |||
} | |||
|
|||
.input:error { | |||
-fx-background-color: #f31111; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just asking:
Maybe a red border looks better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried but it doesn't change the border color of the existing border. Instead it adds a new rectangular border around it. Looks really strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait. I used the wrong field in the CSS.
Build finished. |
Jenkins Build Success +1 |
Build finished. |
Jenkins Build Success +1 |
requires PhoenicisOrg/scripts#376
When you click "Create shortcut" in the library sidebar, a new details view opens:
If you do not fill the form properly, it marks the wrong fields and shows an error message in a tooltip:
fixes #1060