Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added possibility to configure new shortcut when creating it #1069

Merged
merged 4 commits into from
Aug 28, 2017
Merged

added possibility to configure new shortcut when creating it #1069

merged 4 commits into from
Aug 28, 2017

Conversation

plata
Copy link
Collaborator

@plata plata commented Aug 28, 2017

requires PhoenicisOrg/scripts#376

When you click "Create shortcut" in the library sidebar, a new details view opens:
details

If you do not fill the form properly, it marks the wrong fields and shows an error message in a tooltip:
error

fixes #1060

@PlayOnLinuxBOT
Copy link

Build finished.
Jenkins Build Success +1

@PlayOnLinuxBOT
Copy link

Jenkins Build Success +1

@madoar
Copy link
Collaborator

madoar commented Aug 28, 2017

I think it would be more intuitive if we add a red background or border to the textfields that are wrong.
In addition we could show the error message as a tooltip.
What do you think?

@PlayOnLinuxBOT
Copy link

Build finished.
Jenkins Build Success +1

@PlayOnLinuxBOT
Copy link

Jenkins Build Success +1

@@ -602,6 +602,10 @@
-fx-font-family: "Roboto Light";
}

.input:error {
-fx-background-color: #f31111;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just asking:
Maybe a red border looks better?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but it doesn't change the border color of the existing border. Instead it adds a new rectangular border around it. Looks really strange.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait. I used the wrong field in the CSS.

@PlayOnLinuxBOT
Copy link

Build finished.
Jenkins Build Success +1

@PlayOnLinuxBOT
Copy link

Jenkins Build Success +1

@plata plata merged commit b0d08b0 into PhoenicisOrg:master Aug 28, 2017
@plata plata deleted the create-shortcut-options branch August 28, 2017 10:58
@PlayOnLinuxBOT
Copy link

Build finished.
Jenkins Build Success +1

@PlayOnLinuxBOT
Copy link

Jenkins Build Success +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to manually add a new shortcut
3 participants