Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the engine specific location path to the engine implementation in the scripts repository #984

Closed
madoar opened this issue Aug 19, 2017 · 2 comments · Fixed by PhoenicisOrg/scripts#350

Comments

@madoar
Copy link
Collaborator

madoar commented Aug 19, 2017

Currently the wineprefix folder location is set inside a configuration file in the POL 5 repository.
This is kind of bad, because this requires us to add the paths for all later engines to the POL 5 repository too. Therefore I suggest to split the path in two parts.

  • the first part of the path ${application.user.root}/containers/ describes the root location, where all engines should be located. This path should be set from inside POL 5.
  • the second part of the path, which is engine specific, i.e. for wine wineprefix should be set from inside the engines.

For more details, please take a look at #980

@plata
Copy link
Collaborator

plata commented Aug 19, 2017

I've just looked into the scripts. The wineprefix property is used in several places. So we cannot easily remove it. I'm thinking if it makes sense to have a wineprefix folder inside containers at all. How about having all containers in one directory and adding the type to phoenicis.cfg?

@madoar
Copy link
Collaborator Author

madoar commented Aug 19, 2017

Hmm, I don't know. I think it is useful to distinguish different container types by using directories, but I could also imagine using a config file (i.e. phoenicis.cfg) for this.
@qparis what do you think?

plata added a commit to PhoenicisOrg/scripts that referenced this issue Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants